Wessel T wessel
  • Netherlands
  • https://wessel.gg
  • Hey there, I'm Wessel. I like to keep things simple.

    That's also why I like to use C.

  • Joined on 2025-08-14
wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

private variables should be suffixed with _

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

Group commonly used functions together, such as serial functions, mqtt functions, etc.

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

Are all these libs actually needed?

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

Tab, enter

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

Abundant comment

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

formatting

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

in hpp, parent_ is ambiguous name

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

of geen -> for no, remove empty else

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

Formatting through whole document is messed up, mainly extra whitespaces

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

Whitespace

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

Whitespace

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

The file names should be UpperCamelCase, just like all other nodes.

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

Same as LifecycleManager.md

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

???

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

As GPT as somethign can be, maybe reword to use own vocab

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

Use real name (IMU Reader)

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

Please check spelling, whole word usage, etc.

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

Firnattubg

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

can be 1 command

wessel commented on pull request inholland/ros2-assignments#10 2025-11-05 08:26:46 +01:00
[PR] Create lifecycle node

Rename to DefaultParameterDeclarationTest