Wessel T wessel
  • Netherlands
  • https://wessel.gg
  • Hey there, I'm Wessel. I like to keep things simple.

    That's also why I like to use C.

  • Joined on 2025-08-14
wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

Formatting

wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

Abundant comment if the line below it says the same

wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

Enums can also be overloaded with the << operator to support printing them to the console

wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

Isn't there a way to do this with something like an enum? This is a very bad way to communicate states inbetween classes. I'd personally do this with a statuscode that can be mapped to an enum if ros2 doesn't support this

wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

Formatting, and I personally prefer to either comment unused variables, prefix them with _ or name them a _ outright.

wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

Formatting as said above

wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

Abundant comment

wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

Please check formatting of all documents, also see a lot of { on newlines

wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

// assignments::one::retake_grade_determinator

wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

Explain why it is in a separate thread, it is quite self explanatory that it is executed in a separate thread, but why?

wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

I'd write this as

wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

Same as above

wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

Same counts for here, add a comment if you need to clarify why this is done, but most compilers know to ignore _ named variables.

wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

Spaces instead of tabs, 1 tab

wessel commented on pull request inholland/ros2-assignments#6 2025-10-08 13:23:47 +02:00
[PR] Implement retake nodes

This does not need to be a class-wide variable

wessel created pull request inholland/ros2-assignments#7 2025-10-07 19:53:24 +02:00
WIP: [PR] Add unit tests to documentation, add README, add launchfile
130b495030 docs: Add unit tests
62995c13c2 fix(exam_result_generator): Fix timestamp being 0
wessel pushed to 1-grade-generator/master at inholland/ros2-assignments 2025-10-05 18:34:10 +02:00
f147a6e287 Merge pull request '[PR] Make the delay between random grades a parameter' (#5) from 1-grade-generator/exam_result_generator into 1-grade-generator/master
c1559bcd10 feat(exam_result_generator): Make delay between grades a parameter
Compare 2 commits »
wessel merged pull request inholland/ros2-assignments#5 2025-10-05 18:34:08 +02:00
[PR] Make the delay between random grades a parameter