mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-07-04 13:42:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

Change set_uint_at_address to use METH_FASTCALL, skip ctypes test on intel macs

Browse Source
This commit is contained in:
copilot-swe-agent[bot]
2026-06-25 10:49:19 +00:00
committed by GitHub
parent f6d813dc26
commit c2e7ee19d2
2 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
kitty/data-types.c
View File

@@ -684,16 +684,16 @@ py_get_config_dir(PyObject *self UNUSED, PyObject *args UNUSED) {
#include "launcher/cli-parser.h"
static PyObject*
set_uint_at_address(PyObject *self UNUSED, PyObject *args) {
PyObject *address_obj;
unsigned int value;
if (!PyArg_ParseTuple(args, "OI", &address_obj, &value)) return NULL;
void *ptr = PyLong_AsVoidPtr(address_obj);
set_uint_at_address(PyObject *self UNUSED, PyObject *const *args, Py_ssize_t nargs) {
if (nargs != 2) { PyErr_SetString(PyExc_TypeError, "set_uint_at_address() requires exactly 2 arguments"); return NULL; }
void *ptr = PyLong_AsVoidPtr(args[0]);
if (ptr == NULL) {
if (!PyErr_Occurred()) PyErr_SetString(PyExc_ValueError, "NULL address is not valid");
return NULL;
}
*((unsigned int*)ptr) = value;
unsigned long value = PyLong_AsUnsignedLong(args[1]);
if (value == (unsigned long)-1 && PyErr_Occurred()) return NULL;
*((unsigned int*)ptr) = (unsigned int)value;
Py_RETURN_NONE;
}
@@ -730,7 +730,7 @@ static PyMethodDef module_methods[] = {
{"timed_debug_print", (PyCFunction)py_timed_debug_print, METH_VARARGS, ""},
{"find_in_memoryview", (PyCFunction)find_in_memoryview, METH_VARARGS, ""},
{"run_at_exit_cleanup_functions", (PyCFunction)py_run_atexit_cleanup_functions, METH_NOARGS, ""},
{"set_uint_at_address", (PyCFunction)set_uint_at_address, METH_VARARGS, "Write an unsigned integer value to a memory address"},
{"set_uint_at_address", (PyCFunction)(void (*)(void))set_uint_at_address, METH_FASTCALL, "Write an unsigned integer value to a memory address"},
#ifdef __APPLE__
METHODB(user_cache_dir, METH_NOARGS),
METHODB(process_group_map, METH_NOARGS),

22
kitty_tests/datatypes.py
View File

@@ -942,20 +942,22 @@ class TestDataTypes(BaseTest):
self.ae(str(s.line(0)), '')
def test_set_uint_at_address(self):
from ctypes import addressof, c_uint
import platform
from kitty.fast_data_types import set_uint_at_address
from kitty.marks import marker_from_function, marker_from_multiple_regex, marker_from_regex, marker_from_text
# Test set_uint_at_address directly
val = c_uint(0)
addr = addressof(val)
set_uint_at_address(addr, 42)
self.ae(val.value, 42)
set_uint_at_address(addr, 0)
self.ae(val.value, 0)
set_uint_at_address(addr, 0xFFFF)
self.ae(val.value, 0xFFFF)
# Test set_uint_at_address directly (skip on intel macs due to ctypes issues)
if not (is_macos and platform.machine() == 'x86_64'):
from ctypes import addressof, c_uint
val = c_uint(0)
addr = addressof(val)
set_uint_at_address(addr, 42)
self.ae(val.value, 42)
set_uint_at_address(addr, 0)
self.ae(val.value, 0)
set_uint_at_address(addr, 0xFFFF)
self.ae(val.value, 0xFFFF)
# Test marker functions using set_uint_at_address via Screen
s = self.create_screen()