mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-07-02 20:53:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

Dont hold lock while reporting reaped pids

Browse Source 
Can lead to a deadlock if the python code calls something that tries to
acquire the same lock
This commit is contained in:
Kovid Goyal
2024-05-14 12:21:56 +05:30
parent 46fed6ffa9
commit 6be75ce1c7
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
kitty/child-monitor.c
View File

@@ -948,14 +948,17 @@ monitor_pid(PyObject *self UNUSED, PyObject *args) {
static void
report_reaped_pids(void) {
static ReapedPID pids[64];
size_t i = 0;
children_mutex(lock);
if (reaped_pids_count) {
for (size_t i = 0; i < reaped_pids_count; i++) {
call_boss(on_monitored_pid_death, "ii", (int)reaped_pids[i].pid, reaped_pids[i].status);
for (; i < reaped_pids_count && i < arraysz(pids); i++) {
pids[i] = reaped_pids[i];
}
reaped_pids_count = 0;
}
children_mutex(unlock);
for (size_t n = 0; n < i; n++) { call_boss(on_monitored_pid_death, "li", (long)pids[n].pid, pids[n].status); }
}
static void*