mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-06-08 22:28:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

Wayland: Fix a regression in the previous release that broke copying to clipboard under wl-roots based compositors in some circumstances

Browse Source 
As is usual in Wayland land, utter chaos. Divergent implementations,
incorrect interpretations of the spec, bla bla.

Fixes #6890
This commit is contained in:
Kovid Goyal
2023-12-08 08:38:08 +05:30
parent 92befa26db
commit 69a5c7e3b2
2 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
docs/changelog.rst
View File

@@ -54,6 +54,9 @@ Detailed list of changes
- A new action :ac:`send_key` to simplify mapping key presses to other keys without needing :ac:`send_text`
- Wayland: Fix a regression in the previous release that broke copying to clipboard under wl-roots based compositors in some circumstances
(:iss:`6890`)
0.31.0 [2023-11-08]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

14
glfw/wl_window.c vendored
View File

@@ -2034,9 +2034,19 @@ _glfwPlatformSetClipboard(GLFWClipboardType t) {
f(data_source, cd->mime_types[i]);
}
if (t == GLFW_CLIPBOARD) {
// According to the Wayland spec only the application that has keyboard focus can set the clipboard.
// According to some interpretations of the Wayland spec only the application that has keyboard focus can set the clipboard.
// Hurray for the Wayland nanny state!
wl_data_device_set_selection(_glfw.wl.dataDevice, _glfw.wl.dataSourceForClipboard, _glfw.wl.keyboard_enter_serial);
//
// However in wl-roots based compositors, using the serial from the keyboard enter event doesn't work. No clue what
// the correct serial to use here is. Given this Wayland there probably isn't one. What a joke.
// Bug report: https://github.com/kovidgoyal/kitty/issues/6890
// Ironically one of the contributors to wl_roots claims the keyboard enter serial is the correct one to use:
// https://emersion.fr/blog/2020/wayland-clipboard-drag-and-drop/
// The Wayland spec itself says "serial number of the event that triggered this request"
// https://wayland.freedesktop.org/docs/html/apa.html#protocol-spec-wl_data_device
// So who the fuck knows. Just use the latest received serial and ask anybody that uses Wayland
// to get their head examined.
wl_data_device_set_selection(_glfw.wl.dataDevice, _glfw.wl.dataSourceForClipboard, _glfw.wl.serial);
} else {
// According to the Wayland spec we can only set the primary selection in response to a pointer button event
// Hurray for the Wayland nanny state!