mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-06-12 03:29:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

Micro optimize by using hb_buffer_add_codepoints

Browse Source 
This skips harfbuzz buffer validation which we dont need since out
codepoints are already valid. HarfBuzz docs claim it does "deep-sanity
checking" no idea what that is, but I dont think its actually
necessary, we will see if it causes any actual text rendering
regressions.
This commit is contained in:
Kovid Goyal
2025-02-16 10:44:13 +05:30
parent f218be564b
commit 4005fb5bfb
1 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
kitty/fonts.c
View File

@@ -1103,18 +1103,16 @@ render_box_cell(FontGroup *fg, RunFont rf, CPUCell *cpu_cell, GPUCell *gpu_cell,
static void
load_hb_buffer(CPUCell *first_cpu_cell, index_type num_cells, const TextCache *tc, ListOfChars *lc) {
index_type num;
size_t num = 0;
hb_buffer_clear_contents(harfbuzz_buffer);
while (num_cells) {
for (num = 0; num_cells; first_cpu_cell++, num_cells--) {
if (first_cpu_cell->is_multicell && first_cpu_cell->x) continue;
text_in_cell(first_cpu_cell, tc, lc);
const size_t count = MIN(lc->count, arraysz(shape_buffer) - num);
memcpy(shape_buffer + num, lc->chars, count * sizeof(shape_buffer[0]));
num += count;
}
hb_buffer_add_utf32(harfbuzz_buffer, shape_buffer, num, 0, num);
for (; num_cells; first_cpu_cell++, num_cells--) {
if (first_cpu_cell->is_multicell && first_cpu_cell->x) continue;
text_in_cell(first_cpu_cell, tc, lc);
const size_t count = MIN(lc->count, arraysz(shape_buffer) - num);
memcpy(shape_buffer + num, lc->chars, count * sizeof(shape_buffer[0]));
num += count;
}
hb_buffer_add_codepoints(harfbuzz_buffer, shape_buffer, num, 0, num);
hb_buffer_guess_segment_properties(harfbuzz_buffer);
if (OPT(force_ltr)) hb_buffer_set_direction(harfbuzz_buffer, HB_DIRECTION_LTR);
}