mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-06-06 01:05:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

fsync before rename for atomic write

Browse Source
This commit is contained in:
Kovid Goyal
2024-07-22 20:04:13 +05:30
parent c906314974
commit 1b6f74da65
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tools/utils/atomic-write.go
View File

@@ -61,13 +61,12 @@ func AtomicWriteFile(path string, data io.Reader, perm os.FileMode) (err error)
removed = true
}
}()
_, err = io.Copy(f, data)
if err == nil {
err = f.Chmod(perm)
if err == nil {
err = os.Rename(f.Name(), path)
if err == nil {
removed = true
if _, err = io.Copy(f, data); err == nil {
if err = f.Chmod(perm); err == nil {
if err = f.Sync(); err == nil { // Sync before rename to ensure we dont end up with a zero sized file
if err = os.Rename(f.Name(), path); err == nil {
removed = true
}
}
}
}