inholland/ros2-assignments
3
1
Fork 0
generated from wessel/boilerplate
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PR] Implement ESP32-IMU code #8

Merged
wessel merged 9 commits from 2-imu-reader/esp32-IMU into 2-imu-reader/master 2025-11-03 13:02:54 +01:00
Conversation 1 Commits 9 Files Changed 11 +4830
vincent commented 2025-11-03 11:57:10 +01:00
Member
Copy Link

Add code for reading data from an MPU6886 and sending this via MQTT or Serial to control program

Add code for reading data from an MPU6886 and sending this via MQTT or Serial to control program
vincent added 5 commits 2025-11-03 11:57:12 +01:00
feat(esp32-IMU): Upload IMU program progress 93ac1a41e2 
MQTT - functions

TODO:
  - Fix Serial
fix(clean): Remove unused function f952f81390
fix(serial): Exchange ESP_LOGI for printf, up cycletime to 500ms d83a7b21b4
fix(message): Remove unecessary identifier d09364f3c6
fix(esp32-IMU): Add MQTT/Serial toggle 3265359c5c
vincent requested review from inholland 2025-11-03 11:57:14 +01:00
vincent requested review from wessel 2025-11-03 11:58:25 +01:00
wessel approved these changes 2025-11-03 12:07:15 +01:00
wessel left a comment
Owner
Copy Link

Wederom alleen maar een paar styling dingetjes, voor de rest ziet het er goed uit ;}

Wederom alleen maar een paar styling dingetjes, voor de rest ziet het er goed uit ;}
IMU/.editorconfig Outdated
@@ -0,0 +1,75 @@
[*]
wessel commented 2025-11-03 12:01:38 +01:00
Owner
Copy Link

Ik zou deze editorconfig verwijderen aangezien wij al eentje in de hoofdmap hebben ;)

Ik zou deze editorconfig verwijderen aangezien wij al eentje in de hoofdmap hebben ;)
IMU/main/mpu6886.c Outdated
@@ -0,0 +1,299 @@
#include "mpu6886.h"
#include <string.h>
wessel commented 2025-11-03 12:03:34 +01:00
Owner
Copy Link

whitespace

whitespace
vincent marked this conversation as resolved
IMU/main/mpu6886.c Outdated
@@ -0,0 +4,4 @@
#ifdef CONFIG_ENV_MQTT_ENABLED
static void wifi_init()
{
wessel commented 2025-11-03 12:03:46 +01:00
Owner
Copy Link

formatting

formatting
IMU/sdkconfig Outdated
@@ -0,0 +1,2274 @@
#
# Automatically generated file. DO NOT EDIT.
wessel commented 2025-11-03 12:06:25 +01:00
Owner
Copy Link

Is this required in git?

Is this required in git?
vincent commented 2025-11-03 12:44:12 +01:00
Author
Member
Copy Link

jup, dit zijn de settings van de ESP, waaronder MQTT en bootloader instellingen enz.

jup, dit zijn de settings van de ESP, waaronder MQTT en bootloader instellingen enz.
wessel marked this conversation as resolved
IMU/sdkconfig.old Outdated
@@ -0,0 +1,2049 @@
#
wessel commented 2025-11-03 12:06:48 +01:00
Owner
Copy Link

Achtergebleven temp file neem ik aan? (.old)

Achtergebleven temp file neem ik aan? (.old)
vincent commented 2025-11-03 12:44:31 +01:00
Author
Member
Copy Link

klopt zal deze weghalen uit de git

klopt zal deze weghalen uit de git
wessel marked this conversation as resolved
wessel added 2 commits 2025-11-03 12:12:18 +01:00
fix(esp32-IMU): Add MQTT/Serial toggle 3265359c5c
fix(esp32-IMU): Add MQTT/Serial toggle d26e428f99
vincent added 2 commits 2025-11-03 12:51:28 +01:00
fix(styling): Remove whitespace, unnecesary header and add comment 5c52b94876
feat(clarity): Add wiring diagram 5c625e60ab
vincent added 1 commit 2025-11-03 12:55:35 +01:00
fix(formatting): Fixed formatting 6697bd2129
vincent added 1 commit 2025-11-03 12:57:15 +01:00
fix(unused file): Remove unnecessary file 13c88ee703
wessel merged commit 550c1e5581 into 2-imu-reader/master 2025-11-03 13:02:54 +01:00
wessel added the Assignment 2Kind/Feature
Priority
High
2
 labels 2025-11-04 22:07:03 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
inholland
wessel
Labels
Clear labels
Assignment 1
Assignment 2
Assignment 3
Assignment 4
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Assignment 2 Kind/Feature
Priority
High
2
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
wessel
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: inholland/ros2-assignments#8
Delete Branch "2-imu-reader/esp32-IMU"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?