inholland/ros2-assignments
3
1
Fork 0
generated from wessel/boilerplate
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(FinalGradeDeterminator): Make db_manager optional for testing

Browse Source
This commit is contained in:
Vincent Kompjoeteraar Winter
2025-10-04 10:16:59 +02:00
parent a325e19a41
commit d89f47833e
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/g2_2025_grade_calculator_pkg/src/final_grade_determinator/nodes/FinalGradeDeterminator.cpp
View File

@@ -2,12 +2,16 @@
namespace assignments::one::final_grade_determinator { namespace assignments::one::final_grade_determinator {
FinalGradeDeterminator::FinalGradeDeterminator() : Node("final_grade_determinator") { FinalGradeDeterminator::FinalGradeDeterminator(std::unique_ptr<DatabaseManager> db_manager) : Node("final_grade_determinator") {
this->declare_parameter("grade_collection_amount", 5); this->declare_parameter("grade_collection_amount", 5);
grade_collection_amount_ = this->get_parameter("grade_collection_amount").as_int(); grade_collection_amount_ = this->get_parameter("grade_collection_amount").as_int();
// Make db_manager optional for testing purposes
if (db_manager) {
db_manager_ = std::move(db_manager);
} else {
db_manager_ = std::make_unique<DatabaseManager>(this->get_logger()); db_manager_ = std::make_unique<DatabaseManager>(this->get_logger());
}
// Create publisher for exam results // Create publisher for exam results
student_publisher_ = this->create_publisher<g2_2025_interfaces::msg::Student>( student_publisher_ = this->create_publisher<g2_2025_interfaces::msg::Student>(
"student_course_management", 10 "student_course_management", 10

2
src/g2_2025_grade_calculator_pkg/src/final_grade_determinator/nodes/FinalGradeDeterminator.hpp
View File

@@ -18,7 +18,7 @@ namespace assignments::one::final_grade_determinator {
class FinalGradeDeterminator : public rclcpp::Node { class FinalGradeDeterminator : public rclcpp::Node {
public: public:
FinalGradeDeterminator(); FinalGradeDeterminator(std::unique_ptr<DatabaseManager> db_manager = nullptr);
private: private:
rclcpp::Subscription<g2_2025_interfaces::msg::Exam>::SharedPtr exam_subscriber_; rclcpp::Subscription<g2_2025_interfaces::msg::Exam>::SharedPtr exam_subscriber_;
rclcpp::Publisher<g2_2025_interfaces::msg::Student>::SharedPtr student_publisher_; rclcpp::Publisher<g2_2025_interfaces::msg::Student>::SharedPtr student_publisher_;