inholland/ros2-assignments
3
1
Fork 0
generated from wessel/boilerplate
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(retake_nodes): Fix parameter and add comment

Browse Source
This commit is contained in:
Vincent Kompjoeteraar Winter
2025-10-09 13:29:16 +02:00
committed by Wessel Tip
parent ced37955ee
commit bdf5c3b113
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/g2_2025_grade_calculator_pkg/src/retake_grade_determinator/nodes/RetakeGradeDeterminator.cpp
View File

@@ -139,7 +139,7 @@ rclcpp_action::CancelResponse RetakeGradeDeterminator::cancel_callback(
void RetakeGradeDeterminator::spawn_callback_thread( void RetakeGradeDeterminator::spawn_callback_thread(
const std::shared_ptr<rclcpp_action::ServerGoalHandle<g2_2025_interfaces::action::Retake>> goal_handle const std::shared_ptr<rclcpp_action::ServerGoalHandle<g2_2025_interfaces::action::Retake>> goal_handle
) { ) { // Spawn a new thread to prevent blocking the executor
std::thread{std::bind(&RetakeGradeDeterminator::async_execute_callback_thread, this, std::placeholders::_1), goal_handle}.detach(); std::thread{std::bind(&RetakeGradeDeterminator::async_execute_callback_thread, this, std::placeholders::_1), goal_handle}.detach();
} }

4
src/g2_2025_grade_calculator_pkg/src/retake_scheduler/nodes/RetakeScheduler.cpp
View File

@@ -3,8 +3,8 @@
namespace assignments::one::retake_scheduler { namespace assignments::one::retake_scheduler {
RetakeScheduler::RetakeScheduler(std::unique_ptr<DatabaseManager> db_manager) : Node("retake_scheduler") { RetakeScheduler::RetakeScheduler(std::unique_ptr<DatabaseManager> db_manager) : Node("retake_scheduler") {
this->declare_parameter("retake_check_interval", 120); // Default to 120 seconds this->declare_parameter("retake_check_interval_sec", 120); // Default to 120 seconds
retake_check_interval_ = this->get_parameter("retake_check_interval").as_int(); retake_check_interval_ = this->get_parameter("retake_check_interval_sec").as_int();
// Make db_manager optional for testing purposes // Make db_manager optional for testing purposes
if (db_manager) { if (db_manager) {