mirrors/termscp
1
0
Fork 0
mirror of https://github.com/veeso/termscp.git synced 2026-06-08 14:18:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: use time-based redraw interval instead of progress-delta threshold

Browse Source 
The old 1% progress threshold caused the UI to appear frozen on large
files (e.g. 1GB) because many read/write iterations passed between
redraws. Switching to a 100ms time-based interval ensures consistent
UI responsiveness regardless of file size.
This commit is contained in:
Christian Visintin
2026-03-21 21:41:34 +01:00
parent 9b19240925
commit 534c16427e
1 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/ui/activities/filetransfer/session/transfer.rs
View File

@@ -360,7 +360,7 @@ impl FileTransferActivity {
// Write remote file // Write remote file
let mut total_bytes_written: usize = 0; let mut total_bytes_written: usize = 0;
let mut last_progress_val: f64 = 0.0; let mut last_redraw: Instant = Instant::now();
let mut last_input_event_fetch: Option<Instant> = None; let mut last_input_event_fetch: Option<Instant> = None;
// While the entire file hasn't been completely written, // While the entire file hasn't been completely written,
// Or filetransfer has been aborted // Or filetransfer has been aborted
@@ -407,12 +407,11 @@ impl FileTransferActivity {
}; };
// Increase progress // Increase progress
self.transfer.progress.add_bytes(delta); self.transfer.progress.add_bytes(delta);
// Draw only if a significant progress has been made (performance improvement) // Redraw at most every 100ms to keep UI responsive for large files
if last_progress_val < self.transfer.progress.calc_progress() - 0.01 { if last_redraw.elapsed().as_millis() >= 100 {
// Draw
self.update_progress_bar(format!("Uploading \"{file_name}\"…")); self.update_progress_bar(format!("Uploading \"{file_name}\"…"));
self.view(); self.view();
last_progress_val = self.transfer.progress.calc_progress(); last_redraw = Instant::now();
} }
} }
// Finalize stream // Finalize stream
@@ -766,7 +765,7 @@ impl FileTransferActivity {
.register_file(remote.metadata.size as usize); .register_file(remote.metadata.size as usize);
let file_started = Instant::now(); let file_started = Instant::now();
// Write host_bridge file // Write host_bridge file
let mut last_progress_val: f64 = 0.0; let mut last_redraw: Instant = Instant::now();
let mut last_input_event_fetch: Option<Instant> = None; let mut last_input_event_fetch: Option<Instant> = None;
// While the entire file hasn't been completely read, // While the entire file hasn't been completely read,
// Or filetransfer has been aborted // Or filetransfer has been aborted
@@ -811,12 +810,11 @@ impl FileTransferActivity {
}; };
// Set progress // Set progress
self.transfer.progress.add_bytes(delta); self.transfer.progress.add_bytes(delta);
// Draw only if a significant progress has been made (performance improvement) // Redraw at most every 100ms to keep UI responsive for large files
if last_progress_val < self.transfer.progress.calc_progress() - 0.01 { if last_redraw.elapsed().as_millis() >= 100 {
// Draw
self.update_progress_bar(format!("Downloading \"{file_name}\"")); self.update_progress_bar(format!("Downloading \"{file_name}\""));
self.view(); self.view();
last_progress_val = self.transfer.progress.calc_progress(); last_redraw = Instant::now();
} }
} }
// If download was abrupted, return Error // If download was abrupted, return Error