From df6c42f526c6bdde7a7fb807ce2ef61e1262f728 Mon Sep 17 00:00:00 2001 From: alexsparkes Date: Tue, 21 May 2024 16:56:24 +0100 Subject: [PATCH] fix: achievement toast styling, marketplace general improvements Co-authored-by: David Ralph Co-authored-by: Isaac --- .../marketplace/components/Items/Items.jsx | 6 ++-- src/features/marketplace/views/Browse.jsx | 36 +++++++++---------- src/features/marketplace/views/ItemPage.jsx | 3 -- src/features/misc/sections/Experimental.jsx | 11 ++++++ src/scss/_toast.scss | 5 +++ 5 files changed, 35 insertions(+), 26 deletions(-) diff --git a/src/features/marketplace/components/Items/Items.jsx b/src/features/marketplace/components/Items/Items.jsx index 5b3127ec..0c362e27 100644 --- a/src/features/marketplace/components/Items/Items.jsx +++ b/src/features/marketplace/components/Items/Items.jsx @@ -72,8 +72,8 @@ function Items({ showCreateYourOwn, }) { const shouldShowCollection = - (collection && !onCollection && (filter === null || filter === '')) || - (type === 'collections' && !onCollection && (filter === null || filter === '')); + ((collection && !onCollection && (filter === null || filter === '')) || + (type === 'collections' && !onCollection && (filter === null || filter === ''))) && type !== 'preset_settings'; return ( <> @@ -126,7 +126,7 @@ function Items({ ))}
- {showCreateYourOwn ? ( + {!onCollection && showCreateYourOwn ? (
{variables.getMessage('modals.main.marketplace.cant_find')} diff --git a/src/features/marketplace/views/Browse.jsx b/src/features/marketplace/views/Browse.jsx index dc077d5b..d57185c8 100644 --- a/src/features/marketplace/views/Browse.jsx +++ b/src/features/marketplace/views/Browse.jsx @@ -310,31 +310,23 @@ class Marketplace extends PureComponent { if (this.state.done === false) { return errorMessage( - <> -
-
- {variables.getMessage('modals.main.loading')} -
- , +
+
+ {variables.getMessage('modals.main.loading')} +
, ); } if (!this.state.items || this.state.items?.length === 0) { this.getItems(); - return ( + return errorMessage( <> - {errorMessage( - <> - - - {variables.getMessage('modals.main.addons.empty.title')} - - - {variables.getMessage('modals.main.marketplace.no_items')} - - , - )} - + + {variables.getMessage('modals.main.addons.empty.title')} + + {variables.getMessage('modals.main.marketplace.no_items')} + + , ); } @@ -380,7 +372,11 @@ class Marketplace extends PureComponent { onClick={() => this.installCollection()} disabled={this.state.busy} icon={} - label={this.state.busy ? variables.getMessage('modals.main.marketplace.installing') : variables.getMessage('modals.main.marketplace.add_all')} + label={ + this.state.busy + ? variables.getMessage('modals.main.marketplace.installing') + : variables.getMessage('modals.main.marketplace.add_all') + } />
diff --git a/src/features/marketplace/views/ItemPage.jsx b/src/features/marketplace/views/ItemPage.jsx index e4c5f78b..b4449164 100644 --- a/src/features/marketplace/views/ItemPage.jsx +++ b/src/features/marketplace/views/ItemPage.jsx @@ -54,7 +54,6 @@ class ItemPage extends PureComponent { (item) => item.type === convertedType && item.name !== this.props.data.data.name, ), }); - console.log(this.state.curator); } catch (e) { console.error(e); } @@ -157,8 +156,6 @@ class ItemPage extends PureComponent { ); - console.log(this.props.data.data) - return ( <> EventBus.emit(eventType, eventName)} label="Send" /> +