mirrors/mue
1
0
Fork 0
mirror of https://github.com/mue/mue.git synced 2026-07-14 20:43:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

Optimise the code and add a test for something

Browse Source
This commit is contained in:
David Ralph
2020-04-03 19:42:46 +01:00
parent 127045bbf6
commit da4e1cbc81
2 changed files with 10 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/components/Background.jsx
View File

@@ -14,7 +14,9 @@ export default class Background extends React.Component {
const photo = Math.floor(Math.random() * (20 - 1 + 1)) + 1; // There are 20 images in the offline-images folder
document.getElementById('backgroundCredits').style.display = 'none'; // Hide the location icon
let photographer; // Photographer credit
switch (photo) { // Select photographer based on image file number
let pixabayNumbers = [2, 3, 9, 11, 13, 14, 15]; // As there are a lot of Pixabay photos, we shorten the code a bit here
if (pixabayNumbers.includes(photo)) photographer = 'Pixabay';
else switch (photo) {
default: {
photographer = 'Unknown';
break;
@@ -23,14 +25,6 @@ export default class Background extends React.Component {
photographer = 'Tirachard Kumtanom';
break;
}
case 2: {
photographer = 'Pixabay';
break;
}
case 3: {
photographer = 'Pixabay';
break;
}
case 4: {
photographer = 'Sohail Na';
break;
@@ -39,30 +33,10 @@ export default class Background extends React.Component {
photographer = 'Miriam Espacio';
break;
}
case 9: {
photographer = 'Pixabay';
break;
}
case 10: {
photographer = 'NO NAME';
break;
}
case 11: {
photographer = 'Pixabay';
break;
}
case 13: {
photographer = 'Pixabay';
break;
}
case 14: {
photographer = 'Pixabay';
break;
}
case 15: {
photographer = 'Pixabay';
break;
}
case 20: {
photographer = 'Fabian Wiktor';
break;