mirrors/mue
1
0
Fork 0
mirror of https://github.com/mue/mue.git synced 2026-07-13 12:07:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(collection): Unnecessary re-render

Browse Source
This commit is contained in:
alexsparkes
2024-06-18 15:46:47 +01:00
parent 8b5b6fe18a
commit c97841701a
2 changed files with 22 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/features/marketplace/components/Collection/Collection.jsx
View File

@@ -1,3 +1,4 @@
import { memo } from 'react';
import { MdOutlineArrowForward, MdOutlineOpenInNew } from 'react-icons/md';
import { Button } from 'components/Elements';
import variables from 'config/variables';
@@ -44,4 +45,5 @@ const Collection = ({ collections, collectionFunction }) => {
);
};
export { Collection as default, Collection };
const MemoizedCollection = memo(Collection);
export { MemoizedCollection as default, MemoizedCollection as Collection };

38
src/features/marketplace/views/ItemPage.jsx
View File

@@ -31,6 +31,20 @@ const ItemPage = () => {
const [shareModal, setShareModal] = useState(false);
const { selectedItem } = useMarketData();
const locale = localStorage.getItem('language');
const shortLocale = locale.includes('_') ? locale.split('_')[0] : locale;
let languageNames = new Intl.DisplayNames([shortLocale], { type: 'language' });
let dateObj, formattedDate;
if (selectedItem?.updated_at) {
dateObj = new Date(selectedItem?.updated_at);
formattedDate = new Intl.DateTimeFormat(shortLocale, {
year: 'numeric',
month: 'long',
day: '2-digit',
}).format(dateObj);
}
const getName = (name) => {
const nameMappings = {
photos: 'photo_packs',
@@ -63,17 +77,17 @@ const ItemPage = () => {
/*if (this.props.data.data.sideload === true) {
return template(variables.getMessage('marketplace:product.sideload_warning'));
}
}*/
if (this.props.data.data.image_api === true) {
if (selectedItem?.image_api === true) {
return template(variables.getMessage('marketplace:product.third_party_api'));
}
if (this.props.data.data.language !== undefined && this.props.data.data.language !== null) {
if (shortLocale !== this.props.data.data.language) {
if (selectedItem?.language !== undefined && selectedItem?.language !== null) {
if (shortLocale !== selectedItem?.language) {
return template(variables.getMessage('marketplace:product.not_in_language'));
}
}*/
}
return null;
};
@@ -259,20 +273,6 @@ const ItemPage = () => {
);
};
const locale = localStorage.getItem('language');
const shortLocale = locale.includes('_') ? locale.split('_')[0] : locale;
let languageNames = new Intl.DisplayNames([shortLocale], { type: 'language' });
let dateObj, formattedDate;
if (selectedItem?.updated_at) {
dateObj = new Date(selectedItem?.updated_at);
formattedDate = new Intl.DateTimeFormat(shortLocale, {
year: 'numeric',
month: 'long',
day: '2-digit',
}).format(dateObj);
}
useEffect(() => {
document.querySelector('#modal').scrollTop = 0;
});