From 7807462c7b5b31343ecb83119469acc02b8f20cb Mon Sep 17 00:00:00 2001
From: David Ralph <me@davidcralph.co.uk>
Date: Sat, 3 Jan 2026 17:52:10 +0000
Subject: [PATCH] fix: lightbox, breadcrumbs, navbar, uninstall

---
 .../MainModal/components/ModalTopBar.jsx      |   4 +-
 .../MainModal/scss/modules/_topBar.scss       |  10 +
 src/config/constants.js                       |   2 +-
 src/features/misc/sections/About.jsx          |   6 -
 src/features/misc/sections/Changelog.jsx      | 189 ++++--------------
 src/features/misc/views/Discover.jsx          |  43 +++-
 6 files changed, 91 insertions(+), 163 deletions(-)

diff --git a/src/components/Elements/MainModal/components/ModalTopBar.jsx b/src/components/Elements/MainModal/components/ModalTopBar.jsx
index 6f551853..d949e665 100644
--- a/src/components/Elements/MainModal/components/ModalTopBar.jsx
+++ b/src/components/Elements/MainModal/components/ModalTopBar.jsx
@@ -49,8 +49,8 @@ function ModalTopBar({
       // Get the last breadcrumb item (the item name)
       const lastCrumb = iframeBreadcrumbs[iframeBreadcrumbs.length - 1];
 
-      // Add current section if available
-      if (currentSection) {
+      // Add current section if available and different from the last crumb
+      if (currentSection && currentSection !== lastCrumb.label) {
         breadcrumbPath.push({
           label: currentSection,
           onClick: () => onBack(), // Clickable to go back
diff --git a/src/components/Elements/MainModal/scss/modules/_topBar.scss b/src/components/Elements/MainModal/scss/modules/_topBar.scss
index 5b44babf..91c03d22 100644
--- a/src/components/Elements/MainModal/scss/modules/_topBar.scss
+++ b/src/components/Elements/MainModal/scss/modules/_topBar.scss
@@ -1,11 +1,21 @@
 @use 'scss/variables' as *;
 
 .modalTopBar {
+  position: sticky;
+  top: 0;
+  z-index: 10;
   display: flex;
   align-items: center;
   justify-content: space-between;
   padding: 1.5rem 1.5rem;
   // width: 100%;
+  
+  @include themed {
+    background: t($modal);
+  }
+  
+  backdrop-filter: blur(10px);
+  border-bottom: 1px solid rgba(255, 255, 255, 0.1);
 
   .topBarLeft {
     display: flex;
diff --git a/src/config/constants.js b/src/config/constants.js
index a5b38ffc..de297807 100644
--- a/src/config/constants.js
+++ b/src/config/constants.js
@@ -6,7 +6,7 @@ export const OPENSTREETMAP_URL = 'https://www.openstreetmap.org';
 
 // Mue URLs
 export const WEBSITE_URL = 'https://muetab.com';
-export const MARKETPLACE_URL = 'https://muetab.com/marketplace';
+export const MARKETPLACE_URL = 'http://localhost:3000/marketplace';
 export const PRIVACY_URL = 'https://muetab.com/privacy';
 export const TRANSLATIONS_URL = 'https://muetab.com/docs/translations';
 export const WEBLATE_URL = 'https://hosted.weblate.org/projects/mue/mue-tab/';
diff --git a/src/features/misc/sections/About.jsx b/src/features/misc/sections/About.jsx
index d7bb88df..e15d80d1 100644
--- a/src/features/misc/sections/About.jsx
+++ b/src/features/misc/sections/About.jsx
@@ -227,12 +227,6 @@ class About extends PureComponent {
               icon={<BiDonateHeart />}
               label={variables.getMessage('modals.main.settings.sections.about.support_donate')}
             />
-            <Button
-              type="linkIconButton"
-              href={'https://github.com/sponsors/' + variables.constants.ORG_NAME}
-              icon={<SiGithubsponsors />}
-              tooltipTitle="Github Sponsors"
-            />
           </div>
         </div>
 
diff --git a/src/features/misc/sections/Changelog.jsx b/src/features/misc/sections/Changelog.jsx
index 03df9dcc..910f8d28 100644
--- a/src/features/misc/sections/Changelog.jsx
+++ b/src/features/misc/sections/Changelog.jsx
@@ -1,169 +1,60 @@
 import variables from 'config/variables';
-import { useState, useEffect, useRef } from 'react';
+import { useState } from 'react';
 import { MdOutlineWifiOff } from 'react-icons/md';
-import Modal from 'react-modal';
-
-import Lightbox from '../../marketplace/components/Elements/Lightbox/Lightbox';
 
 const Changelog = () => {
-  const [title, setTitle] = useState(null);
-  const [content, setContent] = useState(null);
-  const [date, setDate] = useState(null);
-  const [image, setImage] = useState(null);
-  const [error, setError] = useState(false);
-  const [showLightbox, setShowLightbox] = useState(false);
-  const [lightboxImg, setLightboxImg] = useState(null);
+  const [isLoading, setIsLoading] = useState(true);
   
   const offlineMode = localStorage.getItem('offlineMode') === 'true';
-  const controllerRef = useRef(new AbortController());
-  const changelog = useRef();
+  const isOffline = navigator.onLine === false || offlineMode;
 
-  const parseMarkdown = (text) => {
-    if (typeof text !== 'string') {
-      throw new Error('Input must be a string');
-    }
-
-    // Replace markdown syntax
-    text = text
-      .replace(/\*\*(.*?)\*\*/g, '<strong>$1</strong>')
-      .replace(/^## (.*$)/gm, '<span class="title">$1</span>')
-      .replace(
-        /((http|https):\/\/[^\s]+)/g,
-        '<a href="$1" target="_blank" rel="noopener noreferrer">$1</a>',
-      )
-      // resolve @ to github user link
-      .replace(
-        /@([a-zA-Z0-9-_]+)/g,
-        '<a href="https://github.com/$1" target="_blank" class="changelogAt">@$1</a>',
-      );
-
-    // Replace list items
-    text = text.replace(/^\* (.*$)/gm, '<li>$1</li>');
-
-    // Wrap list items in <ul></ul>
-    text = text.replace(/((<li>.*<\/li>\s*)+)/g, '<ul>$1</ul>');
-
-    return text;
+  const handleLoad = () => {
+    setIsLoading(false);
   };
 
-  const getUpdate = async () => {
-    const releases = await fetch(
-      `https://api.github.com/repos/${variables.constants.ORG_NAME}/${variables.constants.REPO_NAME}/releases`,
-      {
-        signal: controllerRef.current.signal,
-      },
-    );
-
-    if (controllerRef.current.signal.aborted === true) {
-      return;
-    }
-
-    // get the release which tag_name is the same as the current version
-    const data = await releases.json();
-    let release = data.find((release) => release.tag_name === variables.constants.VERSION);
-
-    if (!release) {
-      release = data[0];
-    }
-
-    // request the changelog
-    const res = await fetch(release.url, { signal: controllerRef.current.signal });
-
-    if (res.status === 404) {
-      setError(true);
-      return;
-    }
-
-    if (controllerRef.current.signal.aborted === true) {
-      return;
-    }
-
-    const changelog = await res.json();
-    setTitle(changelog.name);
-    setContent(parseMarkdown(changelog.body));
-    setDate(new Date(changelog.published_at).toLocaleDateString());
-  };
-
-  useEffect(() => {
-    if (navigator.onLine === false || offlineMode) {
-      return;
-    }
-
-    getUpdate();
-
-    return () => {
-      // stop making requests
-      controllerRef.current.abort();
-    };
-  }, []);
-
-  const errorMessage = (msg) => {
+  // Show offline error message if offline
+  if (isOffline) {
     return (
       <div className="emptyItems">
-        <div className="emptyMessage">{msg}</div>
+        <div className="emptyMessage">
+          <MdOutlineWifiOff />
+          <h1>{variables.getMessage('modals.main.marketplace.offline.title')}</h1>
+          <p className="description">
+            {variables.getMessage('modals.main.marketplace.offline.description')}
+          </p>
+        </div>
       </div>
     );
-  };
-
-  if (navigator.onLine === false || offlineMode) {
-    return errorMessage(
-      <>
-        <MdOutlineWifiOff />
-        <h1>{variables.getMessage('modals.main.marketplace.offline.title')}</h1>
-        <p className="description">
-          {variables.getMessage('modals.main.marketplace.offline.description')}
-        </p>
-      </>,
-    );
-  }
-
-  if (error === true) {
-    return errorMessage(
-      <>
-        <MdOutlineWifiOff />
-        <span className="title">{variables.getMessage('modals.main.error_boundary.title')}</span>
-        <span className="subtitle">
-          {variables.getMessage('modals.main.error_boundary.message')}
-        </span>
-      </>,
-    );
-  }
-
-  if (!title) {
-    return errorMessage(
-      <div className="loaderHolder">
-        <div id="loader"></div>
-        <span className="subtitle">{variables.getMessage('modals.main.loading')}</span>
-      </div>,
-    );
   }
 
   return (
-    <div className="modalInfoPage changelogtab" ref={changelog}>
-      <span className="mainTitle">{title}</span>
-      <span className="subtitle">Released on {date}</span>
-      {image && (
-        <img
-          draggable={false}
-          src={image}
-          alt={title}
-          className="updateImage"
-        />
+    <div style={{ position: 'relative', width: '100%', minHeight: '100vh' }}>
+      {isLoading && (
+        <div className="loaderHolder" style={{
+          position: 'absolute',
+          top: '50%',
+          left: '50%',
+          transform: 'translate(-50%, -50%)',
+          zIndex: 10
+        }}>
+          <div id="loader"></div>
+          <span className="subtitle">{variables.getMessage('modals.main.loading')}</span>
+        </div>
       )}
-      <div className="updateChangelog" dangerouslySetInnerHTML={{ __html: content }} />
-      <Modal
-        closeTimeoutMS={100}
-        onRequestClose={() => setShowLightbox(false)}
-        isOpen={showLightbox}
-        className="Modal lightBoxModal"
-        overlayClassName="Overlay resetoverlay"
-        ariaHideApp={false}
-      >
-        <Lightbox
-          modalClose={() => setShowLightbox(false)}
-          img={lightboxImg}
-        />
-      </Modal>
+      <iframe
+        src="http://localhost:3000/blog/changelog?embed=true"
+        onLoad={handleLoad}
+        scrolling="no"
+        style={{
+          width: '100%',
+          height: '2000px',
+          minHeight: '100vh',
+          border: 'none',
+          opacity: isLoading ? 0 : 1,
+          transition: 'opacity 0.2s ease-in-out',
+        }}
+        title="Changelog"
+      />
     </div>
   );
 };
diff --git a/src/features/misc/views/Discover.jsx b/src/features/misc/views/Discover.jsx
index b02c8ebd..97508211 100644
--- a/src/features/misc/views/Discover.jsx
+++ b/src/features/misc/views/Discover.jsx
@@ -2,18 +2,31 @@ import variables from 'config/variables';
 import { MARKETPLACE_URL } from 'config/constants';
 import { memo, useEffect, useRef, useState } from 'react';
 import { MdOutlineWifiOff } from 'react-icons/md';
+import Modal from 'react-modal';
 import Tabs from 'components/Elements/MainModal/backend/Tabs';
 import { useMarketplaceInstall } from 'features/marketplace/components/hooks/useMarketplaceInstall';
+import Lightbox from 'features/marketplace/components/Elements/Lightbox/Lightbox';
 
 function DiscoverContent({ category, onBreadcrumbsChange }) {
   const iframeRef = useRef(null);
   const [isLoading, setIsLoading] = useState(true);
+  const [showLightbox, setShowLightbox] = useState(false);
+  const [lightboxImg, setLightboxImg] = useState(null);
   const { installItem, uninstallItem } = useMarketplaceInstall();
 
   // Check for offline mode
   const offlineMode = localStorage.getItem('offlineMode') === 'true';
   const isOffline = navigator.onLine === false || offlineMode;
 
+  // Clear breadcrumbs when component unmounts (navigating away from discover)
+  useEffect(() => {
+    return () => {
+      if (onBreadcrumbsChange) {
+        onBreadcrumbsChange([]);
+      }
+    };
+  }, [onBreadcrumbsChange]);
+
   useEffect(() => {
     // Show loader when category changes
     setIsLoading(true);
@@ -84,7 +97,8 @@ function DiscoverContent({ category, onBreadcrumbsChange }) {
     // Listen for postMessage events from the iframe
     const handleMessage = (event) => {
       // Verify the origin if needed
-      if (event.origin !== MARKETPLACE_URL) {
+      const marketplaceOrigin = new URL(MARKETPLACE_URL).origin;
+      if (event.origin !== marketplaceOrigin) {
         return;
       }
 
@@ -109,7 +123,7 @@ function DiscoverContent({ category, onBreadcrumbsChange }) {
 
         case 'marketplace:item:uninstall':
           if (payload?.item) {
-            uninstallItem(payload.item.type, payload.item.display_name || payload.item.name);
+            uninstallItem(payload.item.type, payload.item.name || payload.item.display_name);
             // Send confirmation back to iframe
             if (iframeRef.current?.contentWindow) {
               iframeRef.current.contentWindow.postMessage(
@@ -148,6 +162,13 @@ function DiscoverContent({ category, onBreadcrumbsChange }) {
           }
           break;
 
+        case 'marketplace:lightbox':
+          if (payload?.photo) {
+            setLightboxImg(payload.photo.url);
+            setShowLightbox(true);
+          }
+          break;
+
         default:
           break;
       }
@@ -181,10 +202,23 @@ function DiscoverContent({ category, onBreadcrumbsChange }) {
 
   return (
     <div style={{ position: 'relative', width: '100%', minHeight: '100vh' }}>
+      <Modal
+        closeTimeoutMS={300}
+        onRequestClose={() => setShowLightbox(false)}
+        isOpen={showLightbox}
+        className="Modal lightBoxModal"
+        overlayClassName="Overlay"
+        ariaHideApp={false}
+      >
+        <Lightbox
+          modalClose={() => setShowLightbox(false)}
+          img={lightboxImg}
+        />
+      </Modal>
       {isLoading && (
         <div className="loaderHolder" style={{
           position: 'absolute',
-          top: '50%',
+          top: '20%',
           left: '50%',
           transform: 'translate(-50%, -50%)',
           zIndex: 10
@@ -200,12 +234,11 @@ function DiscoverContent({ category, onBreadcrumbsChange }) {
         scrolling="no"
         style={{
           width: '100%',
-          height: '2000px',
+          height: '1500px',
           minHeight: '100vh',
           border: 'none',
           opacity: isLoading ? 0 : 1,
           transition: 'opacity 0.2s ease-in-out',
-          overflow: 'hidden',
         }}
         title="Marketplace"
       />