From 5dd11aca94c00c76f40f02dbd3e48a6bacd7b07a Mon Sep 17 00:00:00 2001 From: David Ralph Date: Mon, 22 Mar 2021 22:17:52 +0000 Subject: [PATCH] perf: remove unneeded divs and replace with <>, remove outdated notes code --- src/App.jsx | 4 +-- src/components/modals/Modals.jsx | 6 ++--- src/components/modals/main/Main.jsx | 26 +++++++++---------- .../modals/main/scss/settings/_main.scss | 4 --- .../modals/main/settings/Checkbox.jsx | 4 +-- .../modals/main/settings/Dropdown.jsx | 4 +-- .../modals/main/settings/Slider.jsx | 4 +-- .../modals/main/settings/Switch.jsx | 4 +-- src/components/modals/main/settings/Text.jsx | 4 +-- .../modals/main/settings/sections/About.jsx | 4 +-- .../main/settings/sections/Advanced.jsx | 4 +-- .../main/settings/sections/Appearance.jsx | 4 +-- .../main/settings/sections/Background.jsx | 4 +-- .../main/settings/sections/Changelog.jsx | 4 +-- .../main/settings/sections/Experimental.jsx | 8 +++--- .../main/settings/sections/Greeting.jsx | 4 +-- .../main/settings/sections/Language.jsx | 6 ++--- .../modals/main/settings/sections/Order.jsx | 4 +-- .../modals/main/settings/sections/Quote.jsx | 4 +-- .../modals/main/settings/sections/Search.jsx | 4 +-- .../modals/main/settings/sections/Time.jsx | 20 +++++++------- src/components/modals/main/tabs/Addons.jsx | 6 ++--- .../modals/main/tabs/Marketplace.jsx | 6 ++--- src/components/modals/main/tabs/Settings.jsx | 7 +++-- .../modals/main/tabs/backend/Tab.jsx | 6 ++--- src/components/widgets/navbar/Notes.jsx | 7 +---- src/components/widgets/quote/Quote.jsx | 2 +- src/components/widgets/search/Search.jsx | 6 ++--- 28 files changed, 80 insertions(+), 90 deletions(-) diff --git a/src/App.jsx b/src/App.jsx index 593ea3d7..2f0ce920 100644 --- a/src/App.jsx +++ b/src/App.jsx @@ -25,14 +25,14 @@ export default class App extends React.PureComponent { render() { return ( - + <>
-
+ ); } } diff --git a/src/components/modals/Modals.jsx b/src/components/modals/Modals.jsx index b9a816ad..a7712455 100644 --- a/src/components/modals/Modals.jsx +++ b/src/components/modals/Modals.jsx @@ -9,7 +9,7 @@ const Main = React.lazy(() => import('./main/Main')); const Update = React.lazy(() => import('./update/Update')); const Welcome = React.lazy(() => import('./welcome/Welcome')); //const Feedback = React.lazy(() => import('./components/modals/Feedback')); -const renderLoader = () =>
; +const renderLoader = () => <>; export default class Modals extends React.PureComponent { constructor(...args) { @@ -40,7 +40,7 @@ export default class Modals extends React.PureComponent { render() { return ( - + <> this.setState({ [modal]: true })}/> this.setState({ mainModal: false })} isOpen={this.state.mainModal} className='Modal' overlayClassName={this.state.overlayClassList} ariaHideApp={false}> @@ -56,7 +56,7 @@ export default class Modals extends React.PureComponent { this.setState({ feedbackModal: false })} /> */} - + ); } } \ No newline at end of file diff --git a/src/components/modals/main/Main.jsx b/src/components/modals/main/Main.jsx index e4c0eb91..5547c4e1 100644 --- a/src/components/modals/main/Main.jsx +++ b/src/components/modals/main/Main.jsx @@ -12,19 +12,19 @@ export default function MainModal(props) { const language = window.language; return ( -
+ <> × - -
- -
-
- -
-
- -
-
-
+ +
+ +
+
+ +
+
+ +
+
+ ); } diff --git a/src/components/modals/main/scss/settings/_main.scss b/src/components/modals/main/scss/settings/_main.scss index aece09cd..d8b0dff0 100644 --- a/src/components/modals/main/scss/settings/_main.scss +++ b/src/components/modals/main/scss/settings/_main.scss @@ -49,10 +49,6 @@ h4, display: inline; } -.section { - margin-bottom: 20px; -} - h4 { cursor: pointer; } diff --git a/src/components/modals/main/settings/Checkbox.jsx b/src/components/modals/main/settings/Checkbox.jsx index 56e80f22..409a2bff 100644 --- a/src/components/modals/main/settings/Checkbox.jsx +++ b/src/components/modals/main/settings/Checkbox.jsx @@ -31,13 +31,13 @@ export default class Checkbox extends React.PureComponent { } return ( - + <> this.handleChange()} />} label={text} />
-
+ ); } } diff --git a/src/components/modals/main/settings/Dropdown.jsx b/src/components/modals/main/settings/Dropdown.jsx index 9f54a932..c1fb64fb 100644 --- a/src/components/modals/main/settings/Dropdown.jsx +++ b/src/components/modals/main/settings/Dropdown.jsx @@ -26,14 +26,14 @@ export default class Dropdown extends React.PureComponent { render() { return ( - + <> {this.getLabel()}
-
+ ); } } diff --git a/src/components/modals/main/settings/Slider.jsx b/src/components/modals/main/settings/Slider.jsx index cef48b93..b214258a 100644 --- a/src/components/modals/main/settings/Slider.jsx +++ b/src/components/modals/main/settings/Slider.jsx @@ -29,10 +29,10 @@ export default class Slider extends React.PureComponent { render() { return ( - + <>

{this.props.title} ({this.state.value}{this.props.display}) this.resetItem()}>{this.language.buttons.reset}

this.handleChange(e.target.value)} /> -
+ ); } } diff --git a/src/components/modals/main/settings/Switch.jsx b/src/components/modals/main/settings/Switch.jsx index 231a9b43..bfdedd01 100644 --- a/src/components/modals/main/settings/Switch.jsx +++ b/src/components/modals/main/settings/Switch.jsx @@ -31,14 +31,14 @@ export default class Switch extends React.PureComponent { } return ( - + <> this.handleChange()} />} label={text} labelPlacement='start' />
-
+ ); } } diff --git a/src/components/modals/main/settings/Text.jsx b/src/components/modals/main/settings/Text.jsx index 91f1fd6d..fbf4c3f3 100644 --- a/src/components/modals/main/settings/Text.jsx +++ b/src/components/modals/main/settings/Text.jsx @@ -34,13 +34,13 @@ export default class Text extends React.PureComponent { render() { return ( - + <>

{this.props.title} this.resetItem()}>{this.language.buttons.reset}

{(this.props.textarea === true) ?