From 5b00b3d859a93f6ef239f6cb78dc3ae32c895d92 Mon Sep 17 00:00:00 2001 From: David Ralph Date: Mon, 21 Jun 2021 13:13:16 +0100 Subject: [PATCH] fix: voice search no longer redirects on empty and now has reload warning --- src/components/modals/main/settings/sections/Search.jsx | 2 +- src/components/widgets/search/Search.jsx | 4 ++++ src/components/widgets/search/search.scss | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/components/modals/main/settings/sections/Search.jsx b/src/components/modals/main/settings/sections/Search.jsx index e83dbe5a..2f2461c7 100644 --- a/src/components/modals/main/settings/sections/Search.jsx +++ b/src/components/modals/main/settings/sections/Search.jsx @@ -77,7 +77,7 @@ export default class SearchSettings extends React.PureComponent { <>

{search.title}

- {isChrome ? : null} + {isChrome ? : null} this.setSearchEngine(value)}> {searchEngines.map((engine) => ( diff --git a/src/components/widgets/search/Search.jsx b/src/components/widgets/search/Search.jsx index 72991da5..e2e47113 100644 --- a/src/components/widgets/search/Search.jsx +++ b/src/components/widgets/search/Search.jsx @@ -39,6 +39,10 @@ export default class Search extends React.PureComponent { }; voiceSearch.onend = () => { + if (searchText.value === '') { + return; + } + setTimeout(() => { window.location.href = this.state.url + `?${this.state.query}=` + searchText.value; }, 1000); diff --git a/src/components/widgets/search/search.scss b/src/components/widgets/search/search.scss index f84e7fb7..911b4dea 100644 --- a/src/components/widgets/search/search.scss +++ b/src/components/widgets/search/search.scss @@ -51,6 +51,7 @@ .micIcon { margin-right: 10px; + position: relative !important; } .dark .searchBar {