From 30aa53fdd766b2f8ab9617b177c3f1f3a9d47eda Mon Sep 17 00:00:00 2001 From: alexsparkes Date: Sat, 24 Jan 2026 17:53:44 +0000 Subject: [PATCH] feat(EffectsSettings): update default brightness value to 100 feat(GreetingOptions): refine event title message key for clarity refactor(WelcomeModal): simplify useEffect by removing event bus listener --- .../options/sections/EffectsSettings.jsx | 2 +- .../greeting/options/GreetingOptions.jsx | 2 +- src/features/welcome/Welcome.jsx | 21 ++----------------- 3 files changed, 4 insertions(+), 21 deletions(-) diff --git a/src/features/background/options/sections/EffectsSettings.jsx b/src/features/background/options/sections/EffectsSettings.jsx index bae7af5b..5ee7b376 100644 --- a/src/features/background/options/sections/EffectsSettings.jsx +++ b/src/features/background/options/sections/EffectsSettings.jsx @@ -32,7 +32,7 @@ const EffectsSettings = ({ backgroundFilter, onFilterChange }) => { name="brightness" min="0" max="100" - default="90" + default="100" display="%" marks={values.background} category="backgroundeffect" diff --git a/src/features/greeting/options/GreetingOptions.jsx b/src/features/greeting/options/GreetingOptions.jsx index bf1e5beb..d4802b24 100644 --- a/src/features/greeting/options/GreetingOptions.jsx +++ b/src/features/greeting/options/GreetingOptions.jsx @@ -323,7 +323,7 @@ const GreetingOptions = ({ currentSubSection, onSubSectionChange, sectionName }) >
onSubSectionChange('events', sectionName)} icon={} diff --git a/src/features/welcome/Welcome.jsx b/src/features/welcome/Welcome.jsx index 6f4308ea..45653d34 100644 --- a/src/features/welcome/Welcome.jsx +++ b/src/features/welcome/Welcome.jsx @@ -29,7 +29,7 @@ function WelcomeModal({ modalClose, modalSkip }) { const [importedSettings, setImportedSettings] = useState([]); const finalTab = 6; - // useEffect hook to handle tab changes and event bus listener + // useEffect hook to handle tab changes useEffect(() => { // Get the current welcome tab from local storage const welcomeTab = localStorage.getItem('welcomeTab'); @@ -42,24 +42,7 @@ function WelcomeModal({ modalClose, modalSkip }) { : variables.getMessage('modals.welcome.buttons.finish'), ); } - - // Listener for the 'refresh' event - const refreshListener = (data) => { - if (data === 'welcomeLanguage') { - localStorage.setItem('welcomeTab', currentTab); - localStorage.setItem('bgtransition', false); - window.location.reload(); - } - }; - - // Subscribe to the 'refresh' event - EventBus.on('refresh', refreshListener); - - // Cleanup function to unsubscribe from the 'refresh' event - return () => { - EventBus.off('refresh', refreshListener); - }; - }, [currentTab, finalTab]); + }, [finalTab]); // Function to update the current tab and button text const updateTabAndButtonText = (newTab) => {