mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-06-06 01:05:48 +02:00
Code Issues Packages Projects Releases Wiki Activity
18,318 Commits 26 Branches 137 Tags
ce4defcff44432584c43351e40392b17a70b4313
Commit Graph

1554 Commits

Author SHA1 Message Date
Connor Welsh
fb4d05f7e8 Wayland: Fix crash hiding titlebar on layer-shell windows 
inform_compositor_of_window_geometry() calls xdg_surface_set_window_geometry()
unconditionally, but layer-shell surfaces (e.g. those from `kitten panel`) have
no xdg_surface. With hide_window_decorations set to titlebar-only, the panel hits
this geometry call during creation and dereferences the NULL proxy, crashing in
wl_proxy_get_version() with SIGSEGV.

Guard on window->wl.xdg.surface: layer-shell surfaces manage geometry via the
layer surface, so the xdg call is skipped. Normal toplevels are unaffected.
 2026-05-30 16:14:55 -04:00
copilot-swe-agent[bot]
0146b02aaf Fix #10082: Re-apply _NET_WM_STATE for X11 layer shell windows on each show 
Some window managers (e.g. kwin_x11) clear _NET_WM_STATE when a window
is unmapped/withdrawn. This caused layer shell windows to lose states like
_NET_WM_STATE_ABOVE, _NET_WM_STATE_SKIP_TASKBAR, etc. when hidden and
re-shown via toggle. The result was inconsistent behaviour between the
first show and subsequent shows.

Fix by calling update_wm_hints() before XMapWindow in
_glfwPlatformShowWindow() for layer shell windows, which re-applies all
WM state properties (_NET_WM_STATE, window type, strut, size hints)
before each map operation.
 2026-05-28 02:07:59 +00:00
Kovid Goyal
2096948cbc Wayland: Only use key repeat events from server is repeat rate == 0 
Fixes #10070
 2026-05-26 08:31:52 +05:30
Kovid Goyal
a17b2df580 Fix #10054 2026-05-22 07:57:41 +05:30
copilot-swe-agent[bot]
9ef08fd865 glfw/input.c: fix dedup to swap duplicates to end instead of overwriting pointers 
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/071dfd57-73e7-4daa-8d35-955bec8b1c4b

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
 2026-05-19 02:12:29 +00:00
copilot-swe-agent[bot]
1aaae286a8 glfw/input.c: remove duplicate mimetypes in _glfwInputDropEvent using verstable 
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/2d7a111f-7d98-4cb0-b085-823736cbf5db

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
 2026-05-19 02:00:12 +00:00
copilot-swe-agent[bot]
c7ded8b8fd fix: send XdndStatus(rejected) instead of XdndFinished on non-accepting window 
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/dc998620-35db-456d-8355-63e39f385464

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
 2026-05-18 05:02:06 +00:00
Kovid Goyal
3118901800 Add some DnD debug statements for X11 2026-05-18 10:20:16 +05:30
Kovid Goyal
57a94d132f When hardlink fails fallback to full copy 2026-05-17 21:12:34 +05:30
Kovid Goyal
f4463703b1 Create a placeholder directory rather than a file when we are transferring directories 2026-05-17 12:40:12 +05:30
Kovid Goyal
75b99a3cbf Fix drop state update on move incorrect when transitioning between windows 2026-05-17 07:50:41 +05:30
Kovid Goyal
613e1ccbe3 ... 2026-05-16 16:58:32 +05:30
Kovid Goyal
0e3a193db6 macOS APIs are really really bonkers 2026-05-16 16:49:47 +05:30
Kovid Goyal
ffec9a854a macOS: Resolve file reference URLs before using them to populate text/uri-list 2026-05-16 16:28:50 +05:30
Kovid Goyal
12e2f80df3 Dont make temp dir world writeable 2026-05-16 13:24:45 +05:30
Kovid Goyal
c278e82ab5 Rewrite macOS drop handling code to workaround Apple's insanely limited API 2026-05-16 13:06:23 +05:30
Kovid Goyal
418ea57382 Have fire_drag_finished cleanup even if no window is present 2026-05-15 13:39:31 +05:30
Kovid Goyal
7e42ef73d3 file promise providers are anyway stored globally so no need to store them on draggingItem's user info 2026-05-15 13:34:53 +05:30
Kovid Goyal
69800d89c0 ... 2026-05-15 13:31:22 +05:30
Kovid Goyal
320bd90ebb macOS: Pass drop intent to OS 2026-05-15 12:58:53 +05:30
Kovid Goyal
35cd3d37f2 Fix dnd from remote to finder on macOS 2026-05-15 10:00:38 +05:30
Kovid Goyal
2a903c724c Fix missing Block_copy 2026-05-15 08:22:30 +05:30
copilot-swe-agent[bot]
d3b12031bd replace C11 atomics with dispatch_group_t to fix undeclared identifier errors 
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/2f0107b0-a6e4-447c-8178-60d65038df4b

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
 2026-05-14 11:38:44 +00:00
copilot-swe-agent[bot]
983185cc62 use atomic counter and url.absoluteString in file-promise uri-list implementation 
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/c28b23d9-b2b8-42d8-914c-85a253d34b12

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
 2026-05-14 11:16:44 +00:00
copilot-swe-agent[bot]
71dbfcd7ff implement TODO: receive file promises into temp dir for text/uri-list DnD on macOS 
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/c28b23d9-b2b8-42d8-914c-85a253d34b12

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
 2026-05-14 11:12:51 +00:00
Kovid Goyal
e9b41513d4 ... 2026-05-14 16:32:35 +05:30
Kovid Goyal
1ff9165335 Store uri-list items as promises correctly 2026-05-14 16:25:29 +05:30
Kovid Goyal
61ea2b4a38 ... 2026-05-14 15:27:26 +05:30
Kovid Goyal
307717213b Set the correct filename for uri-list items 2026-05-14 14:42:52 +05:30
Kovid Goyal
7b30364bfd Allow setting filename for file promise provider 2026-05-14 14:37:11 +05:30
Kovid Goyal
938c3956bd ... 2026-05-14 14:03:44 +05:30
Kovid Goyal
a061e0782e Fix is_remote_client not being passed along 2026-05-14 13:48:18 +05:30
Kovid Goyal
d44a11a4a8 ... 2026-05-14 13:28:44 +05:30
copilot-swe-agent[bot]
344fa2bc5f Extract update_drop_source_actions helper in cocoa backend to avoid duplication 
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/91dbd1d2-ae9d-4816-b710-7d6f3147cda6

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
 2026-05-14 05:49:20 +00:00
copilot-swe-agent[bot]
077f402bee Implement source_actions for X11 and cocoa DnD backends 
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/91dbd1d2-ae9d-4816-b710-7d6f3147cda6

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
 2026-05-14 05:46:21 +00:00
Kovid Goyal
6d4371f596 Properly pass source actions to drop events 
Implemented for Wayland. Needs implementation for X11 and macOS
 2026-05-14 11:07:52 +05:30
Kovid Goyal
5eee2c54ce Bloody Apple native apps refuse to accept drops if a private MIME type is present. Sigh. Back to the drawing board. 2026-05-14 08:25:58 +05:30
Kovid Goyal
f2c79ed7c7 Add debug logging for NSDraggingSession 2026-05-14 08:16:03 +05:30
Kovid Goyal
c2a7225657 Ensure drag finish timer doesnt fire will waiting for remote item data 2026-05-13 10:59:44 +05:30
copilot-swe-agent[bot]
217a01cfdf Implement promised_data_ready() in glfw/cocoa_window.m 
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/38f75cd7-b61b-42b4-9d28-9a40459a9536

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
 2026-05-13 03:03:47 +00:00
Kovid Goyal
c909809bb4 More work on DnD kitten 2026-05-13 08:25:14 +05:30
Kovid Goyal
b28712bfae More work on the DnD kitten 2026-05-13 07:17:06 +05:30
Kovid Goyal
824b46507c Keep text/uri-list as private MIME for kitty to kitty DnD 2026-05-12 13:20:35 +05:30
Kovid Goyal
e4eb85216d Cleanup previous PR 2026-05-08 21:24:38 +05:30
copilot-swe-agent[bot]
e99a6c686b Add DRAG_FINISH_TIMEOUT_SECONDS named constant for the 2-second timeout 
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/5f783d91-e095-4f98-9d13-9d6359889ea2

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
 2026-05-08 15:29:11 +00:00
copilot-swe-agent[bot]
2b4c51707f Fix GLFW_DRAG_FINSHED never firing after GLFW_DRAG_DROPPED on macOS 
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/5f783d91-e095-4f98-9d13-9d6359889ea2

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
 2026-05-08 15:27:36 +00:00
Kovid Goyal
46c83298e3 dnd kitten: get local -> finder working 2026-05-08 20:34:30 +05:30
Kovid Goyal
9e8bd7207b Track remote client on drag source items 2026-05-08 16:54:20 +05:30
copilot-swe-agent[bot]
6f5ac9f342 Fix macOS drag MOVE events: check mimes_count not drag_accepted in draggingUpdated 
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/c5e95934-f4e3-4ba9-8b12-5240a853fd3a

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
 2026-05-06 10:33:13 +00:00
Kovid Goyal
3896846b63 Fix self drops on macOS 2026-05-05 12:42:09 +05:30