Commit Graph

38 Commits

Author SHA1 Message Date
Kovid Goyal
8996aa798c dnd kitten: Create regular files with O_EXCL to avoid symlink attacks
This is not really needed as the terminal emulator should be de
duplicating directory entries anyway but no harm in defense in depth.
2026-06-03 12:17:38 +05:30
copilot-swe-agent[bot]
7af3f4ee83 Refactor dnd kitten: track num_dropped_files instead of data_has_been_dropped
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/84513fee-68de-4504-b41b-e8643e0ea585

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-18 08:44:07 +00:00
Kovid Goyal
6da5bae945 Cleanup previous PR 2026-05-18 13:55:48 +05:30
copilot-swe-agent[bot]
9bb33ac25a Address code review: clarify comments and simplify mime stripping
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/dd371733-fa08-484e-888a-8d0ebdadb853

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-18 07:59:00 +00:00
copilot-swe-agent[bot]
d5a6c072d9 Add data URI support to dnd kitten parse_uri_list
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/dd371733-fa08-484e-888a-8d0ebdadb853

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-18 07:54:57 +00:00
Kovid Goyal
2a59bfe9a0 Dont request the same MIME type multiple times 2026-05-18 13:08:49 +05:30
Kovid Goyal
32e6e834a6 Some cleanups 2026-05-18 11:14:11 +05:30
copilot-swe-agent[bot]
8acb6e7ecb Address review comments: rename variable and improve comments
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/41b8254d-fc79-4f41-9775-67d1ddfceb5b

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-14 02:53:15 +00:00
copilot-swe-agent[bot]
66dca3cde1 Fix dnd kitten: restrict drop to boxes matching drag source allowed operations
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/41b8254d-fc79-4f41-9775-67d1ddfceb5b

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-14 02:49:17 +00:00
Kovid Goyal
0cddb39d95 More work on dnd kitten 2026-05-08 22:23:29 +05:30
Kovid Goyal
5ec8c52025 ... 2026-05-06 12:15:08 +05:30
Kovid Goyal
e024f33b70 ... 2026-05-06 08:53:23 +05:30
copilot-swe-agent[bot]
13898e73f2 Implement --exit-on flag for dnd kitten
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/b6835902-79c3-4d14-9761-8633073db808

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-05 10:33:11 +00:00
copilot-swe-agent[bot]
fe6807c9b0 implement move deletion and add tests for dnd kitten drop
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/e2238746-2319-43e5-9b01-4899e7f06b50

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-05 09:37:50 +00:00
Kovid Goyal
9a3f3ed14e ... 2026-05-05 14:54:09 +05:30
Kovid Goyal
d70ec000ff Start work on drag source implementation 2026-04-30 15:06:22 +05:30
Kovid Goyal
79bf7ef1a4 Cleanup previous PR 2026-04-30 09:23:22 +05:30
copilot-swe-agent[bot]
0615823d15 Add text/uri-list edge case tests and overwrite confirmation tests to dnd_kitten_drop
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/cc433db7-b78f-4174-a6a7-1ba6e51955ac

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-04-29 13:27:02 +00:00
Kovid Goyal
1d6f695140 More work on dnd kitten 2026-04-29 17:46:12 +05:30
Kovid Goyal
bd5fbad8eb Avoid EMFILE errors when there are too many in flight data requests 2026-04-29 13:21:35 +05:30
Kovid Goyal
86c055d96a More work on dnd kitten 2026-04-29 12:40:46 +05:30
Kovid Goyal
9a6f4c3fb8 More work on dnd kitten 2026-04-27 17:31:23 +05:30
Kovid Goyal
ffc39cabfd code cleanup 2026-04-27 09:54:16 +05:30
Kovid Goyal
8c2c32a5a5 More work on the dnd kitten 2026-04-27 08:22:17 +05:30
Kovid Goyal
3e46fa9f81 More work on dnd kitten 2026-04-26 22:55:11 +05:30
Kovid Goyal
db2d5e0111 More work on dnd kitten 2026-04-26 21:07:28 +05:30
Kovid Goyal
151fb9220f More work on dnd kitten 2026-04-26 20:45:41 +05:30
Kovid Goyal
20bd31db0b Allow multiple drops on the dnd kitten 2026-04-26 18:42:14 +05:30
Kovid Goyal
eb6eb37613 Remove option used only for testing 2026-04-26 13:50:10 +05:30
Kovid Goyal
5146cb388b Fix various minor bugs in copy folders 2026-04-25 13:02:27 +05:30
Kovid Goyal
0a384ffad4 DRYer 2026-04-24 15:15:03 +05:30
Kovid Goyal
0f81bca430 DRYer 2026-04-24 14:37:34 +05:30
Kovid Goyal
708987f0d9 ... 2026-04-24 10:49:12 +05:30
Kovid Goyal
a47ec50d72 More work on the dnd kitten 2026-04-23 17:23:21 +05:30
Kovid Goyal
4c6f7ff6b5 Modify drop protocol to allow transmission of broken symlinks in the URI list 2026-04-23 12:36:22 +05:30
Kovid Goyal
3cf037d263 More work on the dnd kitten 2026-04-23 12:04:05 +05:30
Kovid Goyal
04b80e49b0 Move drop code into its own file 2026-04-23 09:15:54 +05:30
Kovid Goyal
b3221f1cd7 Move render code into its own file 2026-04-23 08:51:28 +05:30