Commit Graph

2076 Commits

Author SHA1 Message Date
copilot-swe-agent[bot]
8acb6e7ecb Address review comments: rename variable and improve comments
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/41b8254d-fc79-4f41-9775-67d1ddfceb5b

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-14 02:53:15 +00:00
copilot-swe-agent[bot]
66dca3cde1 Fix dnd kitten: restrict drop to boxes matching drag source allowed operations
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/41b8254d-fc79-4f41-9775-67d1ddfceb5b

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-14 02:49:17 +00:00
Kovid Goyal
9b27f095c8 A couple more places to expand ~ 2026-05-14 06:21:07 +05:30
Kovid Goyal
a771b1d7e5 Expand ~ when processing args for dnd kitten 2026-05-14 06:13:53 +05:30
gogongxt
56f276580f Fix hints kitten breaking multi-byte UTF-8 characters when overlaying hint labels
In highlight_mark(), mark_text was sliced using byte-based indexing
(mark_text[:len(hint)] and mark_text[len(hint):]). Since len(hint)
equals the rune count (hint is always ASCII), but len(mark_text) is a
byte count, this could slice in the middle of a multi-byte UTF-8
sequence (e.g. CJK characters), producing an invalid byte sequence
rendered as the Unicode replacement character (�).

Fix by converting mark_text to []rune first, then slicing at rune
boundaries. The hint is ASCII so len(hint) == rune count, requiring
no conversion on the hint side.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 17:09:42 +08:00
Kovid Goyal
b9261c4e26 Fix failing test
Ensure we never write empty payloads for symlinks/dir listings
2026-05-12 12:52:04 +05:30
Kovid Goyal
2bda489698 Clear remote_item_write_id on completion
Needed as send next remote item checks it is zero before sending
2026-05-12 12:39:34 +05:30
Kovid Goyal
02cfa89bae ... 2026-05-11 21:59:45 +05:30
Kovid Goyal
634f13e65f More work on dnd kitten 2026-05-11 21:51:23 +05:30
Kovid Goyal
0cddb39d95 More work on dnd kitten 2026-05-08 22:23:29 +05:30
Kovid Goyal
5de8734ce3 choose-files kitten: Output a trailing newline when writing to a tty in text format
Fixes #9982
2026-05-07 08:53:09 +05:30
Kovid Goyal
fb7b5d7155 Turn on mouse tracking so text is not selected in the dnd kitten 2026-05-06 17:22:19 +05:30
Kovid Goyal
5ec8c52025 ... 2026-05-06 12:15:08 +05:30
Kovid Goyal
e024f33b70 ... 2026-05-06 08:53:23 +05:30
Kovid Goyal
247ac6df59 Drag source delete on drop should only be done for remote drops 2026-05-05 21:49:42 +05:30
Kovid Goyal
c224fae023 Merge branch 'copilot/delete-files-on-drag-drop' of https://github.com/kovidgoyal/kitty 2026-05-05 21:47:44 +05:30
copilot-swe-agent[bot]
6129fd66b3 Delete source files on move drag, clear drag_sources and allow_drags
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/2f6384ba-c55a-4842-83a9-4cf1b0937420

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-05 16:10:19 +00:00
Kovid Goyal
f7c8fe9c78 flag to track if a drag source sends remote data 2026-05-05 21:39:42 +05:30
copilot-swe-agent[bot]
13898e73f2 Implement --exit-on flag for dnd kitten
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/b6835902-79c3-4d14-9761-8633073db808

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-05 10:33:11 +00:00
Kovid Goyal
74787a60d7 New option to control when dnd kitten exits
To be implemented
2026-05-05 15:55:02 +05:30
Kovid Goyal
516ca9a8c4 Dont try to generate drag thumbnail from file contents as its too slow 2026-05-05 15:47:05 +05:30
copilot-swe-agent[bot]
fe6807c9b0 implement move deletion and add tests for dnd kitten drop
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/e2238746-2319-43e5-9b01-4899e7f06b50

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-05 09:37:50 +00:00
Kovid Goyal
9a3f3ed14e ... 2026-05-05 14:54:09 +05:30
Kovid Goyal
898599ff14 Use a fallback icon as drag thumbnail is none is found 2026-05-05 14:47:50 +05:30
Kovid Goyal
3165a47579 More work on the DnD kitten 2026-05-05 10:49:56 +05:30
Kovid Goyal
fd451f5974 Add flag to specify drop directory for dnd kitten 2026-05-05 09:47:12 +05:30
Kovid Goyal
2316a8ce25 More work on dnd kitten 2026-05-04 12:32:56 +05:30
Kovid Goyal
4fe29f2630 dd basic drag thumbnail support to dnd kitten 2026-05-03 22:18:18 +05:30
Kovid Goyal
ee38d3f0c8 Fix failing test 2026-05-03 18:52:54 +05:30
Kovid Goyal
7b93a9b57e Fix double base64 encoding 2026-05-03 17:29:01 +05:30
copilot-swe-agent[bot]
c98c8542ca Fix two bugs in remote DnD drag: missing idx_in_uri_list and stale data_capacity
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/fdd92dca-f2f9-4bb6-9d85-b5daeaa501f7

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-05-03 07:57:06 +00:00
Kovid Goyal
0de313e178 More work on the dnd kitten 2026-05-03 13:06:56 +05:30
Kovid Goyal
a7a7a4fd8f More work on the dnd kitten 2026-05-03 12:09:40 +05:30
Kovid Goyal
7d468cb000 More work on dnd kitten 2026-05-03 06:54:43 +05:30
Kovid Goyal
d3114ec948 More work on the dnd kitten 2026-05-02 15:18:11 +05:30
Kovid Goyal
ff7c6425e6 More work on dnd kitten 2026-05-02 12:16:42 +05:30
Kovid Goyal
511ef6db31 More work on DnD kitten 2026-05-02 08:06:44 +05:30
Kovid Goyal
a89b7099ad More work on dnd kitten 2026-05-01 13:01:03 +05:30
Kovid Goyal
197115cb95 More work on the dnd kitten 2026-05-01 12:37:35 +05:30
Kovid Goyal
bddf6d5bbd More work on dnd kitten 2026-04-30 17:18:57 +05:30
Kovid Goyal
d70ec000ff Start work on drag source implementation 2026-04-30 15:06:22 +05:30
Kovid Goyal
79bf7ef1a4 Cleanup previous PR 2026-04-30 09:23:22 +05:30
copilot-swe-agent[bot]
0615823d15 Add text/uri-list edge case tests and overwrite confirmation tests to dnd_kitten_drop
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/cc433db7-b78f-4174-a6a7-1ba6e51955ac

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-04-29 13:27:02 +00:00
Kovid Goyal
1d6f695140 More work on dnd kitten 2026-04-29 17:46:12 +05:30
Kovid Goyal
bd5fbad8eb Avoid EMFILE errors when there are too many in flight data requests 2026-04-29 13:21:35 +05:30
Kovid Goyal
86c055d96a More work on dnd kitten 2026-04-29 12:40:46 +05:30
Kovid Goyal
2920270fbb Initialize drop_output_dir 2026-04-28 17:32:02 +05:30
Kovid Goyal
9a6f4c3fb8 More work on dnd kitten 2026-04-27 17:31:23 +05:30
Kovid Goyal
ffc39cabfd code cleanup 2026-04-27 09:54:16 +05:30
copilot-swe-agent[bot]
1c63131b72 Fix redundant condition and misleading comment in buildTree helper
Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/2fffdd1f-2d67-4a28-b124-437c26794e25

Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com>
2026-04-27 03:04:15 +00:00