mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-06-08 14:18:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

macOS: Fix --start-as=fullscreen not working when another window is already fullscreen

Browse Source 
Apparently, we need to make the window visible before full screening it.
Sigh. I dont know why Apple insisted on this horrible "fancy"
fullscreen of theirs, it's full of bugs and dog slow.

Fixes #7448
This commit is contained in:
Kovid Goyal
2024-05-19 20:43:38 +05:30
parent 5dd737e991
commit f86102ab88
2 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/changelog.rst
View File

@@ -96,6 +96,8 @@ Detailed list of changes
- launch --hold: Fix hold not working if kernel signals process group with SIGINT (:iss:`7466`) - launch --hold: Fix hold not working if kernel signals process group with SIGINT (:iss:`7466`)
- macOS: Fix --start-as=fullscreen not working when another window is already fullscreen (:iss:`7448`)
0.34.1 [2024-04-19] 0.34.1 [2024-04-19]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

21
glfw/cocoa_window.m
View File

@@ -2647,6 +2647,20 @@ bool _glfwPlatformIsFullscreen(_GLFWwindow* w, unsigned int flags) {
return sm & NSWindowStyleMaskFullScreen; return sm & NSWindowStyleMaskFullScreen;
} }
static void
make_window_fullscreen_after_show(unsigned long long timer_id, void* data) {
(void)timer_id;
unsigned long long window_id = (uintptr_t)data;
for (_GLFWwindow *w = _glfw.windowListHead; w; w = w->next) {
if (w->id == window_id) {
NSWindow *window = w->ns.object;
[window toggleFullScreen: nil];
update_titlebar_button_visibility_after_fullscreen_transition(w, false, true);
break;
}
}
}
bool _glfwPlatformToggleFullscreen(_GLFWwindow* w, unsigned int flags) { bool _glfwPlatformToggleFullscreen(_GLFWwindow* w, unsigned int flags) {
NSWindow *window = w->ns.object; NSWindow *window = w->ns.object;
bool made_fullscreen = true; bool made_fullscreen = true;
@@ -2688,6 +2702,13 @@ bool _glfwPlatformToggleFullscreen(_GLFWwindow* w, unsigned int flags) {
[w->ns.delegate performSelector:@selector(windowDidResize:) withObject:notification afterDelay:0]; [w->ns.delegate performSelector:@selector(windowDidResize:) withObject:notification afterDelay:0];
} else { } else {
bool in_fullscreen = sm & NSWindowStyleMaskFullScreen; bool in_fullscreen = sm & NSWindowStyleMaskFullScreen;
if (!in_fullscreen && !_glfwPlatformWindowVisible(w)) {
// Bug in Apple's fullscreen implementation causes fullscreen to
// not work before window is shown (at creation) if another window
// is already fullscreen. Le sigh. https://github.com/kovidgoyal/kitty/issues/7448
_glfwPlatformAddTimer(0, false, make_window_fullscreen_after_show, (void*)(uintptr_t)(w->id), NULL);
return made_fullscreen;
}
if (in_fullscreen) made_fullscreen = false; if (in_fullscreen) made_fullscreen = false;
[window toggleFullScreen: nil]; [window toggleFullScreen: nil];
} }