From ce5cfdd9caf44c538af800a07162e1f49bd53c35 Mon Sep 17 00:00:00 2001
From: Kovid Goyal <kovid@kovidgoyal.net>
Date: Thu, 20 Mar 2025 14:00:09 +0530
Subject: [PATCH] kitty +open: Ask for confirmation when running executables

Workaround for badly designed program that try to open links in
untrusted documents that point to executables on the local system.
They should really not be doing that, but, since such programs do exist,
let's be safe by default.

Users that use better designed programs and want to disable the
confirmations can do so by writing their own launch-actions.conf
---
 docs/changelog.rst    |  6 ++++++
 kitty/open_actions.py | 12 +++++++-----
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 504a1458a..a9ab48f60 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -102,6 +102,12 @@ Detailed list of changes
   background text colors. Works in a perceptual color for best color accuracy
   (:pull:`8420`)
 
+- :ref:`kitty +open <launch_actions>`: Ask for confirmation by default when running executables
+  to work around some badly designed programs that try to open links in
+  documents that point to executable files. Can be overridden by specifying
+  your own :file:`launch-actions.conf`.
+
+
 0.40.1 [2025-03-18]
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
diff --git a/kitty/open_actions.py b/kitty/open_actions.py
index cbbadbcf1..17332fc55 100644
--- a/kitty/open_actions.py
+++ b/kitty/open_actions.py
@@ -240,25 +240,27 @@ action show_kitty_doc $URL_PATH
 @run_once
 def default_launch_actions() -> tuple[OpenAction, ...]:
     return tuple(parse('''\
-# Open script files
+# Open script files. Change confirm-always to confirm-never or confirm-if-needed to
+# disable confirmation for all or executable files respectively.
 protocol file
 ext sh,command,tool
-action launch --hold --type=os-window kitten __shebang__ confirm-if-needed $FILE_PATH $SHELL
+action launch --hold --type=os-window kitten __shebang__ confirm-always $FILE_PATH $SHELL
 
 # Open shell specific script files
 protocol file
 ext fish,bash,zsh
-action launch --hold --type=os-window kitten __shebang__ confirm-if-needed $FILE_PATH __ext__
+action launch --hold --type=os-window kitten __shebang__ confirm-always $FILE_PATH __ext__
 
 # Open directories
 protocol file
 mime inode/directory
 action launch --type=os-window --cwd -- $FILE_PATH
 
-# Open executable file
+# Open executable file. Remove kitten __confirm_and_run_exe__ to execute
+# without confirmation.
 protocol file
 mime inode/executable,application/vnd.microsoft.portable-executable
-action launch --hold --type=os-window -- $FILE_PATH
+action launch --hold --type=os-window -- kitten __confirm_and_run_exe__ $FILE_PATH
 
 # Open text files without fragments in the editor
 protocol file