mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-07-20 23:44:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix a regression in notify_on_cmd_finish that caused notifications to appear for every command after the first

Browse Source 
Fixes #7725
This commit is contained in:
Kovid Goyal
2024-08-16 20:47:52 +05:30
parent 4575dc6b70
commit bb090ccc72
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/changelog.rst
View File

@@ -138,6 +138,8 @@ Detailed list of changes
- macOS: Bump the minimum required macOS version to Catalina released five years ago. - macOS: Bump the minimum required macOS version to Catalina released five years ago.
- Fix a regression in :opt:`notify_on_cmd_finish` that caused notifications to appear for every command after the first (:iss:`7725`)
0.35.2 [2024-06-22] 0.35.2 [2024-06-22]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

2
kitty/window.py
View File

@@ -1452,13 +1452,13 @@ class Window:
def handle_cmd_end(self, exit_status: str = '') -> None: def handle_cmd_end(self, exit_status: str = '') -> None:
if self.last_cmd_output_start_time == 0.: if self.last_cmd_output_start_time == 0.:
return return
self.last_cmd_output_start_time = 0.
try: try:
self.last_cmd_exit_status = int(exit_status) self.last_cmd_exit_status = int(exit_status)
except Exception: except Exception:
self.last_cmd_exit_status = 0 self.last_cmd_exit_status = 0
end_time = monotonic() end_time = monotonic()
last_cmd_output_duration = end_time - self.last_cmd_output_start_time last_cmd_output_duration = end_time - self.last_cmd_output_start_time
self.last_cmd_output_start_time = 0.
self.call_watchers(self.watchers.on_cmd_startstop, { self.call_watchers(self.watchers.on_cmd_startstop, {
"is_start": False, "time": end_time, 'cmdline': self.last_cmd_cmdline, 'exit_status': self.last_cmd_exit_status}) "is_start": False, "time": end_time, 'cmdline': self.last_cmd_cmdline, 'exit_status': self.last_cmd_exit_status})