mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-07-11 06:34:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

Skip generation increment in background_images() when paths unchanged

Browse Source
This commit is contained in:
copilot-swe-agent[bot]
2026-04-15 17:59:48 +00:00
committed by Kovid Goyal
parent 12a87929c6
commit a348cabe23
3 changed files with 30 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
kitty/options/to-c.h
View File

@@ -178,15 +178,25 @@ free_background_images(Options *opts) {
static inline void
background_images(PyObject *src, Options *opts) {
free_background_images(opts);
static unsigned generation = 0;
size_t new_count = (PyTuple_Check(src) && PyTuple_GET_SIZE(src) > 0) ? (size_t)PyTuple_GET_SIZE(src) : 0;
if (new_count == opts->background_images.count && opts->background_images.paths) {
bool changed = false;
for (size_t i = 0; i < new_count; i++) {
const char *p = PyUnicode_AsUTF8(PyTuple_GET_ITEM(src, i));
if (!p || !opts->background_images.paths[i] || strcmp(p, opts->background_images.paths[i]) != 0) { changed = true; break; }
}
if (!changed) return;
}
free_background_images(opts);
opts->background_images.generation = ++generation;
if (!PyTuple_Check(src) || PyTuple_GET_SIZE(src) == 0) return;
opts->background_images.paths = calloc(PyTuple_GET_SIZE(src), sizeof(opts->background_images.paths[0]));
if (!new_count) return;
opts->background_images.paths = calloc(new_count, sizeof(opts->background_images.paths[0]));
if (opts->background_images.paths) {
opts->background_images.count = PyTuple_GET_SIZE(src);
for (size_t i = 0; i < opts->background_images.count; i++) opts->background_images.paths[i] = strdup(
PyUnicode_AsUTF8(PyTuple_GET_ITEM(src, i)));
opts->background_images.count = new_count;
for (size_t i = 0; i < opts->background_images.count; i++) {
opts->background_images.paths[i] = strdup(PyUnicode_AsUTF8(PyTuple_GET_ITEM(src, i)));
}
}
}