mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-07-18 22:44:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Dont alloc the stream decode buffer on object init

Browse Source
This commit is contained in:
Kovid Goyal
2024-07-26 17:16:13 +05:30
parent 3d0747e713
commit 9de4b7bc78
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
kitty/data-types.c
View File

@@ -118,9 +118,6 @@ StreamingBase64Decoder_init(PyObject *s, PyObject *args, PyObject *kwds) {
unsigned long initial_capacity = 8 * 1024;
if (!PyArg_ParseTupleAndKeywords(args, kwds, "|k", kwlist, &initial_capacity)) return -1;
StreamingBase64Decoder *self = (StreamingBase64Decoder*)s;
self->output = PyBytes_FromStringAndSize(NULL, initial_capacity);
if (!self->output) return -1;
self->output_capacity = initial_capacity;
self->initial_capacity = initial_capacity;
return 0;
}
@@ -138,7 +135,8 @@ write_base64_data(StreamingBase64Decoder *self, const void *data, size_t len) {
size_t sz = required_buffer_size_for_base64_decode(len);
if ((self->output_sz + sz) > self->output_capacity) {
size_t cap = MAX(self->output_capacity * 2, self->output_sz + sz + self->initial_capacity);
if (_PyBytes_Resize(&self->output, cap) != 0) return false;
if (self->output) { if (_PyBytes_Resize(&self->output, cap) != 0) return false; }
else { self->output = PyBytes_FromStringAndSize(NULL, cap); if (!self->output) return false; }
self->output_capacity = cap;
}
if (!base64_decode8(data, len, (unsigned char*)(PyBytes_AS_STRING(self->output) + self->output_sz), &sz)) {
@@ -208,6 +206,7 @@ StreamingBase64Decoder_copy_output(StreamingBase64Decoder *self, PyObject *args
static PyObject*
StreamingBase64Decoder_take_output(StreamingBase64Decoder *self, PyObject *args UNUSED) {
if (!self->output_sz) return PyBytes_FromStringAndSize(NULL, 0);
RAII_PyObject(newbuf, PyBytes_FromStringAndSize(NULL, self->initial_capacity));
if (!newbuf) return NULL;
if (_PyBytes_Resize(&self->output, self->output_sz) != 0) return NULL;