From 9bb33ac25a1d40c6800136684e0bbf11217c1f69 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 18 May 2026 07:59:00 +0000 Subject: [PATCH] Address code review: clarify comments and simplify mime stripping Agent-Logs-Url: https://github.com/kovidgoyal/kitty/sessions/dd371733-fa08-484e-888a-8d0ebdadb853 Co-authored-by: kovidgoyal <1308621+kovidgoyal@users.noreply.github.com> --- kittens/dnd/drop.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/kittens/dnd/drop.go b/kittens/dnd/drop.go index 03fcc2341..13ed2bf6f 100644 --- a/kittens/dnd/drop.go +++ b/kittens/dnd/drop.go @@ -432,9 +432,8 @@ func parse_data_uri(uri string) (mime string, data []byte, err error) { if mime == "" { mime = "text/plain" } - // Strip parameters for extension lookup but keep original for the field - mime_for_ext, _, _ := strings.Cut(mime, ";") - mime = strings.TrimSpace(mime_for_ext) + // Strip parameters (e.g. ;charset=UTF-8) so the MIME type is clean. + mime, _, _ = strings.Cut(mime, ";") if is_base64 { payload = strings.NewReplacer("\r", "", "\n", "", " ", "").Replace(payload) @@ -468,7 +467,9 @@ func parse_uri_list(src string) (ans []parsed_uri, err error) { } else if strings.HasPrefix(line, "data:") { m, d, derr := parse_data_uri(line) if derr != nil { - ans = append(ans, parsed_uri{kind: parsed_uri_file}) // treat invalid data URI as empty entry + // Invalid data URI: treat as an unrecognised entry (empty path) so the caller + // skips it without failing, matching the behaviour for unknown URI schemes. + ans = append(ans, parsed_uri{kind: parsed_uri_file}) } else { ans = append(ans, parsed_uri{kind: parsed_uri_data, mime: m, data: d}) }