mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-07-26 18:22:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Get closing of notifications working on macOS

Browse Source
This commit is contained in:
Kovid Goyal
2024-07-25 16:35:32 +05:30
parent 3593e8d78d
commit 9024341b1f
5 changed files with 50 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
kitty/notifications.py
View File

@@ -279,9 +279,16 @@ class MacOSIntegration(DesktopIntegration):
def initialize(self) -> None:
from .fast_data_types import cocoa_set_notification_activated_callback
self.id_counter = count()
self.id_counter = count(start=1)
cocoa_set_notification_activated_callback(self.notification_activated)
def close_notification(self, desktop_notification_id: int) -> bool:
from .fast_data_types import cocoa_remove_delivered_notification
close_succeeded = cocoa_remove_delivered_notification(str(desktop_notification_id))
if debug_desktop_integration:
log_error(f'Close request for {desktop_notification_id=} {"succeeded" if close_succeeded else "failed"}')
return close_succeeded
def notify(self,
title: str,
body: str,
@@ -293,10 +300,15 @@ class MacOSIntegration(DesktopIntegration):
) -> int:
desktop_notification_id = next(self.id_counter)
from .fast_data_types import cocoa_send_notification
cocoa_send_notification(str(desktop_notification_id), title, body, subtitle, urgency.value)
# If the body is not set macos makes the title the body and uses
# "kitty" as the title. So use a single space for the body in this
# case.
cocoa_send_notification(str(desktop_notification_id), title, body or ' ', subtitle, urgency.value)
return desktop_notification_id
def notification_activated(self, ident: str) -> None:
if debug_desktop_integration:
log_error(f'Notification {ident} activated')
try:
desktop_notification_id = int(ident)
except Exception:
@@ -434,7 +446,10 @@ class NotificationManager:
desktop_integration: Optional[DesktopIntegration] = None,
channel: Channel = Channel(),
log: Log = Log(),
debug: bool = False,
):
global debug_desktop_integration
debug_desktop_integration = debug
if desktop_integration is None:
self.desktop_integration = MacOSIntegration(self) if is_macos else FreeDesktopIntegration(self)
else: