From 8865d3231a029b68cf078a37e62613c7f8db08fd Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Thu, 5 Oct 2023 09:36:59 +0530 Subject: [PATCH] Fix themes that dont define a background color incorrectly being classified as light The default bg in kitty is dark --- tools/themes/collection.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/themes/collection.go b/tools/themes/collection.go index 685c9ee0b..385b7899d 100644 --- a/tools/themes/collection.go +++ b/tools/themes/collection.go @@ -470,8 +470,9 @@ type ThemeMetadata struct { func ParseThemeMetadata(path string) (*ThemeMetadata, map[string]string, error) { var in_metadata, in_blurb, finished_metadata bool - ans := ThemeMetadata{} + ans := ThemeMetadata{Is_dark: true} // the default background in kitty is dark settings := map[string]string{} + read_is_dark := func(key, val string) (err error) { settings[key] = val if key == "background" { @@ -479,7 +480,7 @@ func ParseThemeMetadata(path string) (*ThemeMetadata, map[string]string, error) if val != "" { bg, err := style.ParseColor(val) if err == nil { - ans.Is_dark = utils.Max(bg.Red, bg.Green, bg.Green) < 115 + ans.Is_dark = utils.Max(bg.Red, bg.Green, bg.Blue) < 115 } } }