mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-06-08 14:18:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

More efficient clearing of register to all zeros or all ones

Browse Source
This commit is contained in:
Kovid Goyal
2024-02-01 09:27:49 +05:30
parent 59be7213cf
commit 77cfd44f24
1 changed files with 42 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
tools/simdstring/generate.go
View File

@@ -575,7 +575,7 @@ func (f *Function) Or(a, b, dest Register) {
f.AddTrailingComment(dest, "=", a, "|", b, "(bitwise)") f.AddTrailingComment(dest, "=", a, "|", b, "(bitwise)")
} }
func (f *Function) ZeroRegister(r Register) { func (f *Function) ClearRegisterToZero(r Register) {
defer func() { f.AddTrailingComment("set", r, "to zero") }() defer func() { f.AddTrailingComment("set", r, "to zero") }()
if f.ISA.Goarch == ARM64 { if f.ISA.Goarch == ARM64 {
if r.Size == f.ISA.GeneralPurposeRegisterSize { if r.Size == f.ISA.GeneralPurposeRegisterSize {
@@ -599,6 +599,25 @@ func (f *Function) ZeroRegister(r Register) {
} }
} }
func (f *Function) AllOnesRegister(r Register) {
switch r.Size {
default:
f.CmpEqEpi8(r, r, r)
case f.ISA.GeneralPurposeRegisterSize:
if f.ISA.Goarch == ARM64 {
f.instr("MOVD", "$-1", r)
} else {
switch r.Size {
case 32:
f.instr("MOVL", "$0xFFFFFFFF")
case 64:
f.instr("MOVQ", "$0xFFFFFFFFFFFFFFFF")
}
}
f.AddTrailingComment(r, "= all ones")
}
}
func (f *Function) CopyRegister(a, ans Register) { func (f *Function) CopyRegister(a, ans Register) {
if a.Size != ans.Size { if a.Size != ans.Size {
panic("Can only copy registers of equal sizes") panic("Can only copy registers of equal sizes")
@@ -631,12 +650,19 @@ func (f *Function) SetRegsiterTo(self Register, val any) {
if self.Size != f.ISA.GeneralPurposeRegisterSize { if self.Size != f.ISA.GeneralPurposeRegisterSize {
panic("TODO: Cannot yet set constant values in vector registers") panic("TODO: Cannot yet set constant values in vector registers")
} }
switch v {
case 0:
f.ClearRegisterToZero(self)
case -1:
f.AllOnesRegister(self)
default:
if f.ISA.Goarch == ARM64 { if f.ISA.Goarch == ARM64 {
f.instr("MOVD", val_repr_for_arithmetic(v), self) f.instr("MOVD", val_repr_for_arithmetic(v), self)
} else { } else {
f.instr(f.MemLoadForBasicType(types.Int32), val_repr_for_arithmetic(v), self) f.instr(f.MemLoadForBasicType(types.Int32), val_repr_for_arithmetic(v), self)
} }
f.AddTrailingComment(self, "= ", v) f.AddTrailingComment(self, "= ", v)
}
case string: case string:
f.instr(f.MemLoadForBasicType(types.Uintptr), v) f.instr(f.MemLoadForBasicType(types.Uintptr), v)
f.AddTrailingComment(self, "=", self.Size/8, "bytes at the address", v) f.AddTrailingComment(self, "=", self.Size/8, "bytes at the address", v)
@@ -701,7 +727,7 @@ func (f *Function) Set1Epi8(val any, vec Register) {
do_shuffle_load := func(r Register) { do_shuffle_load := func(r Register) {
f.instr("MOVL", r, vec) f.instr("MOVL", r, vec)
shuffle_mask := f.Vec() shuffle_mask := f.Vec()
f.ZeroRegister(shuffle_mask) f.ClearRegisterToZero(shuffle_mask)
f.instr("PSHUFB", shuffle_mask, vec) f.instr("PSHUFB", shuffle_mask, vec)
f.ReleaseReg(shuffle_mask) f.ReleaseReg(shuffle_mask)
} }
@@ -711,6 +737,15 @@ func (f *Function) Set1Epi8(val any, vec Register) {
default: default:
panic("unknown type for set1_epi8") panic("unknown type for set1_epi8")
case int: case int:
switch v {
case 0:
f.ClearRegisterToZero(vec)
return
case -1:
f.AllOnesRegister(vec)
return
}
f.Comment("Set all bytes of", vec, "to", v) f.Comment("Set all bytes of", vec, "to", v)
r := f.Reg() r := f.Reg()
defer f.ReleaseReg(r) defer f.ReleaseReg(r)