From 77563cebb03c7fc358aa878e179ed21626ca32fe Mon Sep 17 00:00:00 2001 From: Eng Zer Jun Date: Wed, 30 Aug 2023 11:50:52 +0800 Subject: [PATCH] cli/command: remove redundant nil check From the Go specification: "1. For a nil slice, the number of iterations is 0." [1] Therefore, an additional nil check for before the loop is unnecessary. [1]: https://go.dev/ref/spec#For_range Signed-off-by: Eng Zer Jun --- tools/cli/command.go | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tools/cli/command.go b/tools/cli/command.go index 37f15ec71..229aeed49 100644 --- a/tools/cli/command.go +++ b/tools/cli/command.go @@ -417,12 +417,9 @@ func (self *Command) FindOptions(name_with_hyphens string) []*Option { depth := 0 for p := self.Parent; p != nil; p = p.Parent { depth++ - x := p.FindOptions(name_with_hyphens) - if x != nil { - for _, po := range x { - if po.Depth >= depth { - ans = append(ans, po) - } + for _, po := range p.FindOptions(name_with_hyphens) { + if po.Depth >= depth { + ans = append(ans, po) } } }