mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-07-18 14:34:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make serializing data ops avoid a double copy

Browse Source
This commit is contained in:
Kovid Goyal
2023-07-04 22:19:08 +05:30
parent f7723a65fa
commit 6bc0fc7615
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tools/rsync/algorithm.go
View File

@@ -17,8 +17,6 @@ import (
"hash" "hash"
"io" "io"
"os" "os"
"golang.org/x/exp/slices"
) )
// If no BlockSize is specified in the RSync instance, this value is used. // If no BlockSize is specified in the RSync instance, this value is used.
@@ -44,11 +42,16 @@ type Operation struct {
BlockIndex uint64 BlockIndex uint64
BlockIndexEnd uint64 BlockIndexEnd uint64
Data []byte Data []byte
serialized_repr []byte
} }
var bin = binary.LittleEndian var bin = binary.LittleEndian
func (self Operation) Serialize() []byte { func (self Operation) Serialize() []byte {
if self.serialized_repr != nil {
return self.serialized_repr
}
var ans []byte var ans []byte
switch self.Type { switch self.Type {
case OpBlock: case OpBlock:
@@ -399,7 +402,13 @@ func (self *Diff) enqueue(op Operation) {
} }
func (self *Diff) send_data() { func (self *Diff) send_data() {
self.enqueue(Operation{Type: OpData, Data: slices.Clone(self.buffer[self.data.tail:self.data.head])}) data := self.buffer[self.data.tail:self.data.head]
srepr := make([]byte, len(data)+5)
copy(srepr[5:], data)
bin.PutUint32(srepr[1:], uint32(len(data)))
srepr[0] = byte(OpData)
op := Operation{Type: OpData, Data: srepr[5:], serialized_repr: srepr}
self.enqueue(op)
self.data.tail = self.data.head self.data.tail = self.data.head
} }