mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-06-08 14:18:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix rendering of underlines when using larger text sizes with the space and en-space characters

Browse Source 
Fixes #8950
This commit is contained in:
Kovid Goyal
2025-09-04 20:44:35 +05:30
parent 315562d73d
commit 574386f45b
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
docs/changelog.rst
View File

@@ -162,6 +162,9 @@ Detailed list of changes
- Fix a regression in 0.40.0 that broke handling of the VS16 variation selector when it caused a character to flow to the next line (:iss:`8848`) - Fix a regression in 0.40.0 that broke handling of the VS16 variation selector when it caused a character to flow to the next line (:iss:`8848`)
- Fix rendering of underlines when using larger text sizes with the space and
en-space characters (:iss:`8950`)
- Wayland: Update bundled copy of libwayland to 1.24 from 1.23.1 because the - Wayland: Update bundled copy of libwayland to 1.24 from 1.23.1 because the
just released mesa 25.2.0 breaks with libwayland < 1.24 (:iss:`8884`) just released mesa 25.2.0 breaks with libwayland < 1.24 (:iss:`8884`)

9
kitty/fonts.c
View File

@@ -744,7 +744,10 @@ START_ALLOW_CASE_RANGE
if (allow_use_of_box_fonts) return BOX_FONT; if (allow_use_of_box_fonts) return BOX_FONT;
/* fallthrough */ /* fallthrough */
default: default:
if (lc->count == 1 && (lc->chars[0] == ' ' || lc->chars[0] == 0x2002 /* en-space */)) return BLANK_FONT; // Optimisation to avoid rendering spaces, except in the case of
// scaled multicells as the decorations there have to rendered
// scaled as well.
if (lc->count == 1 && (lc->chars[0] == ' ' || lc->chars[0] == 0x2002 /* en-space */) && (!cpu_cell->is_multicell || cpu_cell->scale == 1)) return BLANK_FONT;
*is_emoji_presentation = has_emoji_presentation(cpu_cell, lc); *is_emoji_presentation = has_emoji_presentation(cpu_cell, lc);
ans = in_symbol_maps(fg, lc->chars[0]); ans = in_symbol_maps(fg, lc->chars[0]);
if (ans > -1) return ans; if (ans > -1) return ans;
@@ -1781,7 +1784,9 @@ render_run(FontGroup *fg, CPUCell *first_cpu_cell, GPUCell *first_gpu_cell, inde
render_groups(fg, rf, center_glyph, tc); render_groups(fg, rf, center_glyph, tc);
break; break;
case BLANK_FONT: case BLANK_FONT:
while(num_cells--) { first_gpu_cell->sprite_idx = 0; first_cpu_cell++; first_gpu_cell++; } while (num_cells--) {
first_gpu_cell->sprite_idx = 0; first_cpu_cell++; first_gpu_cell++;
}
break; break;
case BOX_FONT: case BOX_FONT:
while(num_cells) { while(num_cells) {