From 4cb190130f1ef32a13260478a3056cdb3d22b955 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Tue, 19 Nov 2024 08:08:35 +0530 Subject: [PATCH] Document why we explicitly turn off in band resize --- tools/tui/loop/terminal-state.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/tui/loop/terminal-state.go b/tools/tui/loop/terminal-state.go index bfb0c2251..269ec43b4 100644 --- a/tools/tui/loop/terminal-state.go +++ b/tools/tui/loop/terminal-state.go @@ -169,6 +169,10 @@ func (self *TerminalStateOptions) ResetStateEscapeCodes() string { } else { sb.WriteString(SAVE_CURSOR) } + // Explictly turn off this mode as there are some terminals that dont + // support restoring all modes and people tend to use the show-key kitten + // in other terminals. Since I do want to encourage adoption of the kitty + // keyboard protocol, the extra bytes are worth it in this case. if self.in_band_resize_notification { reset_modes(&sb, INBAND_RESIZE_NOTIFICATION) }