From 455d0a6048683b8170829d37718ba73ba5341520 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Tue, 10 Oct 2023 05:33:04 +0530 Subject: [PATCH] Dont show hidden sub-commands during completion --- kitty_tests/completion.py | 3 +-- tools/cli/completion-parse-args.go | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/kitty_tests/completion.py b/kitty_tests/completion.py index b4744f3bc..64c0b356e 100644 --- a/kitty_tests/completion.py +++ b/kitty_tests/completion.py @@ -92,9 +92,8 @@ def completion(self: TestCompletion, tdir: str): self.assertEqual(cp.returncode, 0, f'kitten __complete__ failed with exit code: {cp.returncode}') return json.loads(cp.stdout) - add('kitty ', has_words('@', '@ls', '+', '+open')) + add('kitty ', has_words('@', '+', '+open')) add('kitty @ l', has_words('ls', 'last-used-layout', 'launch')) - add('kitty @l', has_words('@ls', '@last-used-layout', '@launch')) def make_file(path, mode=None): with open(os.path.join(tdir, path), mode='x') as f: diff --git a/tools/cli/completion-parse-args.go b/tools/cli/completion-parse-args.go index 8119b3e97..0e885076e 100644 --- a/tools/cli/completion-parse-args.go +++ b/tools/cli/completion-parse-args.go @@ -104,7 +104,7 @@ func complete_word(word string, completions *Completions, only_args_allowed bool group.Title = "Sub-commands" } for _, sc := range cg.SubCommands { - if strings.HasPrefix(sc.Name, word) { + if !sc.Hidden && strings.HasPrefix(sc.Name, word) { t := sc.ShortDescription if t == "" { t = sc.HelpText