From 2e1e89f280031b648d894c7c83ecb3d09d60d75d Mon Sep 17 00:00:00 2001
From: Kovid Goyal <kovid@kovidgoyal.net>
Date: Sat, 21 Feb 2026 21:30:24 +0530
Subject: [PATCH] Cleanup previous PR

---
 docs/changelog.rst   |  3 +++
 kitty/cocoa_window.h |  1 -
 kitty/cocoa_window.m | 15 +++------------
 3 files changed, 6 insertions(+), 13 deletions(-)

diff --git a/docs/changelog.rst b/docs/changelog.rst
index 4d1786ce9..70dc8bd5e 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -229,6 +229,9 @@ Detailed list of changes
 
 - Wayland: Add support for the background blur extension (:iss:`9534`)
 
+- macOS: A new option :opt:`macos_dock_badge_on_bell` to show a badge on the
+  kitty dock icon when a bell occurs (:pull:`9529`)
+
 
 0.45.0 [2025-12-24]
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
diff --git a/kitty/cocoa_window.h b/kitty/cocoa_window.h
index 4baa1ebad..1779de9e2 100644
--- a/kitty/cocoa_window.h
+++ b/kitty/cocoa_window.h
@@ -67,4 +67,3 @@ void get_cocoa_key_equivalent(uint32_t, int, char *key, size_t key_sz, int*);
 void set_cocoa_pending_action(CocoaPendingAction action, const char*);
 void cocoa_report_live_notifications(const char* ident);
 void cocoa_set_dock_badge(const char *label);
-void cocoa_clear_dock_badge(void);
diff --git a/kitty/cocoa_window.m b/kitty/cocoa_window.m
index dd1f56373..ce7a7c58c 100644
--- a/kitty/cocoa_window.m
+++ b/kitty/cocoa_window.m
@@ -1345,16 +1345,7 @@ void
 cocoa_set_dock_badge(const char *label) {
     @autoreleasepool {
         NSDockTile *dockTile = [NSApp dockTile];
-        [dockTile setBadgeLabel:@(label)];
-        [dockTile display];
-    }
-}
-
-void
-cocoa_clear_dock_badge(void) {
-    @autoreleasepool {
-        NSDockTile *dockTile = [NSApp dockTile];
-        [dockTile setBadgeLabel:nil];
+        [dockTile setBadgeLabel:label ? @(label) : nil];
         [dockTile display];
     }
 }
@@ -1386,8 +1377,8 @@ init_cocoa(PyObject *module) {
         addObserverForName:NSApplicationDidBecomeActiveNotification
         object:nil
         queue:[NSOperationQueue mainQueue]
-        usingBlock:^(NSNotification *note __attribute__((unused))) {
-            cocoa_clear_dock_badge();
+        usingBlock:^(NSNotification *note UNUSED) {
+            cocoa_set_dock_badge(NULL);
         }];
     return true;
 }