From 2cf83070a0b30065011379d46fde2fd6688ef074 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Wed, 12 Feb 2025 11:31:28 +0530 Subject: [PATCH] Report ancient xdg-shell versions --- glfw/wl_init.c | 5 ++++- kitty/options/definition.py | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/glfw/wl_init.c b/glfw/wl_init.c index d5a0ca00f..5063353da 100644 --- a/glfw/wl_init.c +++ b/glfw/wl_init.c @@ -703,7 +703,7 @@ _glfwWaylandCompositorName(void) { static const char* get_compositor_missing_capabilities(void) { -#define C(title, x) if (!_glfw.wl.x) p += snprintf(buf, sizeof(buf) - (p - buf), "%s", #title); +#define C(title, x) if (!_glfw.wl.x) p += snprintf(buf, sizeof(buf) - (p - buf), "%s ", #title); static char buf[256]; char *p = buf; *p = 0; @@ -712,7 +712,10 @@ get_compositor_missing_capabilities(void) { C(cursor_shape, wp_cursor_shape_manager_v1); C(layer_shell, zwlr_layer_shell_v1); C(single_pixel_buffer, wp_single_pixel_buffer_manager_v1); C(preferred_scale, has_preferred_buffer_scale); C(idle_inhibit, idle_inhibit_manager); + if (_glfw.wl.xdg_wm_base_version < 6) p += snprintf(buf, sizeof(buf) - (p - buf), "%s ", "window-state-suspended"); + if (_glfw.wl.xdg_wm_base_version < 5) p += snprintf(buf, sizeof(buf) - (p - buf), "%s ", "window-capabilities"); #undef C + while (p > buf && (p - 1)[0] == ' ') { p--; *p = 0; } return buf; } diff --git a/kitty/options/definition.py b/kitty/options/definition.py index 695726423..759b1a0b1 100644 --- a/kitty/options/definition.py +++ b/kitty/options/definition.py @@ -3307,7 +3307,7 @@ The possible values are: Only send a notification when the window both is unfocused and not visible to the user, for example, because it is in an inactive tab or its OS window is not currently visible (note that OS Window visibility is not implemented - by some Wayland compositors such as sway). + by some Wayland compositors such as sway and also not implemented in X11). :code:`always` Always send a notification, regardless of window state.