Use "with suppress()" to suppress python exceptions

Using
```Python
with suppress(OSError):
    os.remove('somefile.tmp')
```
instead of
```Python
try:
    os.remove('somefile.tmp')
except OSError:
    pass
```
makes the code more compact and more readable IMO.

This pattern was recommended by Raymond Hettinger, a Python Core
Developer in his talk "Transforming Code into Beautiful, Idiomatic Python" at https://www.youtube.com/watch?v=OSGv2VnC0go. The transcript is available at https://github.com/JeffPaine/beautiful_idiomatic_python
This commit is contained in:
Luflosi
2019-06-03 11:50:07 +02:00
parent d6e750727f
commit 2b095f720e
22 changed files with 68 additions and 138 deletions

View File

@@ -8,6 +8,7 @@ import shutil
import subprocess
import sys
import tempfile
from contextlib import suppress
if False:
tarball = sys.argv[-1]
@@ -16,14 +17,10 @@ if False:
os.makedirs(dest)
os.chdir(dest)
dest = os.path.expanduser('~/.local/bin/kitty')
try:
with suppress(EnvironmentError):
os.remove(dest)
except EnvironmentError:
pass
try:
with suppress(EnvironmentError):
os.makedirs(os.path.dirname(dest))
except EnvironmentError:
pass
subprocess.check_call(['tar', 'xJf', tarball])
os.symlink(os.path.abspath('bin/kitty'), dest)
print('kitty installed to ~/.local/kitty.app')