mirrors/kitty
1
0
Fork 0
mirror of https://github.com/kovidgoyal/kitty synced 2026-07-23 16:58:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Have close notifications indicate when notification is not found

Browse Source
This commit is contained in:
Kovid Goyal
2024-07-25 07:58:17 +05:30
parent 095e1917c1
commit 1c9d9e394c
4 changed files with 30 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
kitty_tests/datatypes.py
View File

@@ -584,7 +584,7 @@ class TestDataTypes(BaseTest):
self.assertNotEqual(SingleKey(key=1, mods=2), SingleKey(key=1))
def test_notify_identifier_sanitization(self):
from kitty.notify import sanitize_identifier_pat
from kitty.notifications import sanitize_identifier_pat
self.ae(sanitize_identifier_pat().sub('', '\x1b\nabc\n[*'), 'abc')
def test_bracketed_paste_sanitizer(self):

18
kitty_tests/notifications.py
View File

@@ -93,7 +93,7 @@ def do_test(self: 'TestNotifications') -> None:
n = di.notifications[which]
di.close_notification(n['id'])
def assert_events(focus=True, close=0, report='', close_response=''):
def assert_events(focus=True, close=0, report='', close_response='', enoent=False):
self.ae(ch.focus_events, [''] if focus else [])
if report:
self.assertIn(f'99;i={report};', ch.responses)
@@ -102,7 +102,8 @@ def do_test(self: 'TestNotifications') -> None:
m = re.match(r'99;i=[a-z0-9]+;', r)
self.assertIsNone(m, f'Unexpectedly found report response: {r}')
if close_response:
self.assertIn(f'99;i={close_response}:p=close;', ch.responses)
t = 'ENOENT;' if enoent else ''
self.assertIn(f'99;i={close_response}:p=close;{t}', ch.responses)
else:
for r in ch.responses:
m = re.match(r'99;i=[a-z0-9]+:p=close;', r)
@@ -172,8 +173,21 @@ def do_test(self: 'TestNotifications') -> None:
reset()
h('i=c;title')
h('i=c:p=close;notify')
self.ae(di.notifications, [n()])
assert_events(focus=False, close=True, close_response='c')
reset()
h('i=c;title')
activate()
h('i=c:p=close;notify')
self.ae(di.notifications, [n()])
assert_events(focus=True, close_response='c', enoent=True)
reset()
h('i=c:a=report;title')
activate()
h('i=c:p=close;notify')
self.ae(di.notifications, [n()])
assert_events(focus=True, report='c', close_response='c', enoent=True)
reset()
h(';title')
self.ae(di.notifications, [n()])