From 976f684c04756194fb9aa9a58c9e3cc1ab480dfc Mon Sep 17 00:00:00 2001 From: Wessel Tip Date: Sun, 7 Sep 2025 16:14:04 +0200 Subject: [PATCH] fix(les1): Naming of clock code inconsistent --- src/les_pkg/CMakeLists.txt | 8 +++----- src/les_pkg/src/{les1.cpp => les1/clock.cpp} | 16 +++++++++------- 2 files changed, 12 insertions(+), 12 deletions(-) rename src/les_pkg/src/{les1.cpp => les1/clock.cpp} (81%) diff --git a/src/les_pkg/CMakeLists.txt b/src/les_pkg/CMakeLists.txt index ae3c300..b8bec80 100644 --- a/src/les_pkg/CMakeLists.txt +++ b/src/les_pkg/CMakeLists.txt @@ -12,20 +12,18 @@ find_package(rclcpp_action REQUIRED) # nodig als er een actionserver node word find_package(std_msgs REQUIRED) # gebruik maken von standaard messages find_package(geometry_msgs REQUIRED) # gebruik maken von standaard messages find_package(les_interface REQUIRED) # gebruik maken von standaard messages -#find_package(templates_interfaces REQUIRED) # gebruik maken van project messages - -add_executable(les1 src/les1.cpp) +add_executable(les1_clock src/les1/clock.cpp) add_executable(les1_publisher src/les1/publisher.cpp) add_executable(les1_subscriber src/les1/subscriber.cpp) -ament_target_dependencies(les1 rclcpp) +ament_target_dependencies(les1_clock rclcpp) ament_target_dependencies(les1_publisher rclcpp std_msgs geometry_msgs les_interface) ament_target_dependencies(les1_subscriber rclcpp std_msgs geometry_msgs les_interface) install ( TARGETS - les1 + les1_clock les1_publisher les1_subscriber DESTINATION lib/${PROJECT_NAME} diff --git a/src/les_pkg/src/les1.cpp b/src/les_pkg/src/les1/clock.cpp similarity index 81% rename from src/les_pkg/src/les1.cpp rename to src/les_pkg/src/les1/clock.cpp index 7ad5021..7729fc9 100644 --- a/src/les_pkg/src/les1.cpp +++ b/src/les_pkg/src/les1/clock.cpp @@ -22,8 +22,10 @@ * * Reviewed by: * Changelog: - * [04-09-2025] Wessel T: - * - Implement template + * [04-09-2025] Wessel T: Implement template + * [07-09-2025] Wessel T: + * - Rename {les1.cpp -> les1/clock.cpp} + * - Update node names to be in line with other files */ #include @@ -31,15 +33,15 @@ #include #include -class NodeLes1 : public rclcpp::Node +class NodeLes1Clock : public rclcpp::Node { public: - NodeLes1() - : Node("les1_node") + NodeLes1Clock() + : Node("node_les1_clock") { timer_ = this->create_wall_timer( std::chrono::seconds(1), - std::bind(&NodeLes1::print_time, this) + std::bind(&NodeLes1Clock::print_time, this) ); } @@ -56,7 +58,7 @@ private: int main(int argc,char *argv[]) { rclcpp::init(argc,argv); - auto node = std::make_shared(); + auto node = std::make_shared(); rclcpp::spin(node); rclcpp::shutdown();