From a7a51337be7a1cab9da9225fe6bd7eb696e96c83 Mon Sep 17 00:00:00 2001 From: Vincent W Date: Wed, 1 Oct 2025 15:53:37 +0200 Subject: [PATCH] fix(cleanup): remove unused param, fix formatting remove unused parameter and fix formatting to be like the rest of the project --- .../final_grade_determinator/nodes/FinalGradeDeterminator.cpp | 4 ++-- .../final_grade_determinator/nodes/FinalGradeDeterminator.hpp | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/g2_2025_grade_calculator_pkg/src/final_grade_determinator/nodes/FinalGradeDeterminator.cpp b/src/g2_2025_grade_calculator_pkg/src/final_grade_determinator/nodes/FinalGradeDeterminator.cpp index 2333903..b506be7 100644 --- a/src/g2_2025_grade_calculator_pkg/src/final_grade_determinator/nodes/FinalGradeDeterminator.cpp +++ b/src/g2_2025_grade_calculator_pkg/src/final_grade_determinator/nodes/FinalGradeDeterminator.cpp @@ -24,8 +24,8 @@ FinalGradeDeterminator::FinalGradeDeterminator() : Node("final_grade_determinato } void FinalGradeDeterminator::exam_results_callback(const g2_2025_interfaces::msg::Exam::SharedPtr msg){ - studentCourseCombo_.student_name = msg->student_name; - studentCourseCombo_.course_name = msg->course_name; + studentCourseCombo_.student_name = msg->student_name; + studentCourseCombo_.course_name = msg->course_name; dataMap_[studentCourseCombo_].push_back(msg->result); if (dataMap_[studentCourseCombo_].size() == static_cast(grade_collection_ammount_)) diff --git a/src/g2_2025_grade_calculator_pkg/src/final_grade_determinator/nodes/FinalGradeDeterminator.hpp b/src/g2_2025_grade_calculator_pkg/src/final_grade_determinator/nodes/FinalGradeDeterminator.hpp index ae2c98e..ee00a39 100644 --- a/src/g2_2025_grade_calculator_pkg/src/final_grade_determinator/nodes/FinalGradeDeterminator.hpp +++ b/src/g2_2025_grade_calculator_pkg/src/final_grade_determinator/nodes/FinalGradeDeterminator.hpp @@ -14,8 +14,6 @@ #include "database/DatabaseManager.hpp" #include "database/StudentCourse.hpp" -#define PARAM 5 - namespace assignments::one::final_grade_determinator { class FinalGradeDeterminator : public rclcpp::Node {