fix(fish): ROS2 still initializes even if not in distrobox

fish/environments/templates/ros2.fish

@@ -1,66 +1,65 @@
 # ROS2 development environment (requires distrobox)
 # Environment: {{ENV_NAME}}
 
+# First check if running inside distrobox
+if not test -f /run/.containerenv; and test -z "$CONTAINER_ID"
+    echo (set_color red)"This ROS2 environment should only be run inside a distrobox container"(set_color normal)
+    return 1
+end
+
 # Check if a previous initialization has occurred
 if test -n "$__ENV_INITIALIZED"
     echo (set_color yellow)"Environment already initialized"(set_color normal)
     return 0
 end
 
-# Mark as initialized
+# Mark as initialized (only after distrobox check passes)
 set -gx __ENV_INITIALIZED "1"
 set -gx CURRENT_ENV "{{ENV_NAME}}"
-
-# Check if running inside distrobox
-if test -f /run/.containerenv; or test -n "$CONTAINER_ID"
-    # Source ROS2 setup files using bass
-    if type -q bass
-        bass source /opt/ros/jazzy/setup.bash
-        if test -f ./install/setup.bash
-            bass source ./install/setup.bash
-        end
-    else
-        echo (set_color red)"Error: bass is required for ROS2 environment. Install with: fisher install edc/bass"(set_color normal)
-        return 1
+# Source ROS2 setup files using bass
+if type -q bass
+    bass source /opt/ros/jazzy/setup.bash
+    if test -f ./install/setup.bash
+        bass source ./install/setup.bash
     end
-
-    # Set environment variable for the prompt prefix
-    set -gx ROS2_ACTIVE 1
-
-    # Save the original prompt function if it exists
-    # Only save if we don't already have a backup or if current prompt is not from an environment
-    if not functions -q __env_orig_prompt
-        if functions -q fish_prompt
-            functions -c fish_prompt __env_orig_prompt
-        else
-            function __env_orig_prompt
-                echo -n (whoami)'@'(prompt_hostname)' '(set_color $fish_color_cwd)(prompt_pwd)(set_color normal)'> '
-            end
-        end
-    else
-        # If we already have a backup, we're switching environments
-        # No need to create a new backup
-    end
-
-    # Define new prompt with ROS2 prefix
-    function fish_prompt
-        echo -n (set_color magenta)'({{ENV_NAME}})'(set_color normal)' '
-        __env_orig_prompt
-    end
-
-    # ROS2 aliases and functions
-    alias cb="colcon build"
-    alias cbs="colcon build --symlink-install"
-    alias cbt="colcon build --packages-select"
-    alias ct="colcon test"
-    alias ctr="colcon test-result"
-
-    echo (set_color green)"Activated ROS2 environment: {{ENV_NAME}}"(set_color normal)
 else
-    echo (set_color red)"This ROS2 environment should only be run inside a distrobox container"(set_color normal)
+    echo (set_color red)"Error: bass is required for ROS2 environment. Install with: fisher install edc/bass"(set_color normal)
     return 1
 end
 
+# Set environment variable for the prompt prefix
+set -gx ROS2_ACTIVE 1
+
+# Save the original prompt function if it exists
+# Only save if we don't already have a backup or if current prompt is not from an environment
+if not functions -q __env_orig_prompt
+    if functions -q fish_prompt
+        functions -c fish_prompt __env_orig_prompt
+    else
+        function __env_orig_prompt
+            echo -n (whoami)'@'(prompt_hostname)' '(set_color $fish_color_cwd)(prompt_pwd)(set_color normal)'> '
+        end
+    end
+else
+    # If we already have a backup, we're switching environments
+    # No need to create a new backup
+end
+
+# Define new prompt with ROS2 prefix
+function fish_prompt
+    echo -n (set_color magenta)'({{ENV_NAME}})'(set_color normal)' '
+    __env_orig_prompt
+end
+
+# ROS2 aliases and functions
+alias cb="colcon build"
+alias cbs="colcon build --symlink-install"
+alias cbt="colcon build --packages-select"
+alias ct="colcon test"
+alias ctr="colcon test-result"
+
+echo (set_color green)"Activated ROS2 environment: {{ENV_NAME}}"(set_color normal)
+
 # Custom deactivation function
 function __env_custom_deactivate
     # Remove ROS2-specific variables and aliases